Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 16033003: [CSSRegions] Constrain auto-height region computation in a different way (Closed)

Created:
7 years, 7 months ago by mihnea
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae, leviw_travelin_and_unemployed, jchaffraix+rendering, chromiumbugtracker_adobe.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSSRegions] Constrain auto-height region computation in a different way Since the region is a render block, we can use RenderBox::constrainContentBoxLogicalHeightByMinMax instead of RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight to better reflect the fact that the region is not a replaced element. Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children. BUG=243651 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/rendering/RenderFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
eseidel
eae and levi are the best reviewers for anyting subpixel related.
7 years, 6 months ago (2013-05-28 20:10:06 UTC) #1
eseidel
Bah. Sorry. commented on teh wrong bug. but this lgtm too.
7 years, 6 months ago (2013-05-28 20:10:26 UTC) #2
eseidel
lgtm
7 years, 6 months ago (2013-05-28 20:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihnea@adobe.com/16033003/1
7 years, 6 months ago (2013-05-28 20:10:37 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10581
7 years, 6 months ago (2013-05-28 21:01:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihnea@adobe.com/16033003/1
7 years, 6 months ago (2013-05-29 18:00:59 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10751
7 years, 6 months ago (2013-05-29 18:30:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihnea@adobe.com/16033003/1
7 years, 6 months ago (2013-05-30 05:27:21 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 05:27:43 UTC) #9
Message was sent while issue was closed.
Change committed as 151442

Powered by Google App Engine
This is Rietveld 408576698