Call CreateDefaultOrdinals() when needed, instead of on construction

Call CreateDefaultOrdinals() when needed, instead of on construction

This is not a complete fix, but it appears to be safe and will make 
it much less likely for this to crash while we consider a more complete
solution.

BUG=243773
For browser/extensions:
TBR=asargent@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202337

[stevenjb, 2013-05-24 18:00:52]

asargent@ for OWNER

[csharp, 2013-05-24 18:06:22]

https://chromiumcodereview.appspot.com/16032004/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_sorting.cc (right):

https://chromiumcodereview.appspot.com/16032004/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sorting.cc:549: static bool
s_default_ordinales_created = false;
Why isn't this a class variable?

[xiyuan, 2013-05-24 18:07:17]

LGTM

[xiyuan, 2013-05-24 18:09:13]

https://chromiumcodereview.appspot.com/16032004/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_sorting.cc (right):

https://chromiumcodereview.appspot.com/16032004/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_sorting.cc:549: static bool
s_default_ordinales_created = false;
On 2013/05/24 18:06:22, csharp wrote:
> Why isn't this a class variable?

Right, this needs to be fixed. The flag has to be a member var since we will
have multiple profiles and thus multiple ExtensionSorting.

[stevenjb, 2013-05-24 18:16:02]

PTAL

I fixed the static and also replaced the CHECK with a LOG(ERROR) in
ExternalLoader::GetAppIds() since I think that unordered apps would be better
than a crash.

https://codereview.chromium.org/16032004/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_sorting.cc (right):

https://codereview.chromium.org/16032004/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_sorting.cc:549: static bool
s_default_ordinales_created = false;
On 2013/05/24 18:09:13, xiyuan wrote:
> On 2013/05/24 18:06:22, csharp wrote:
> > Why isn't this a class variable?
> 
> Right, this needs to be fixed. The flag has to be a member var since we will
> have multiple profiles and thus multiple ExtensionSorting.

Ugh, I've been working too much with statics and am developing bad habits.
Fixed.

[xiyuan, 2013-05-24 18:20:11]

On 2013/05/24 18:16:02, stevenjb (chromium) wrote:
> PTAL
> 
> I fixed the static and also replaced the CHECK with a LOG(ERROR) in
> ExternalLoader::GetAppIds() since I think that unordered apps would be better
> than a crash.
> 
>
https://codereview.chromium.org/16032004/diff/1/chrome/browser/extensions/ext...
> File chrome/browser/extensions/extension_sorting.cc (right):
> 
>
https://codereview.chromium.org/16032004/diff/1/chrome/browser/extensions/ext...
> chrome/browser/extensions/extension_sorting.cc:549: static bool
> s_default_ordinales_created = false;
> On 2013/05/24 18:09:13, xiyuan wrote:
> > On 2013/05/24 18:06:22, csharp wrote:
> > > Why isn't this a class variable?
> > 
> > Right, this needs to be fixed. The flag has to be a member var since we will
> > have multiple profiles and thus multiple ExtensionSorting.
> 
> Ugh, I've been working too much with statics and am developing bad habits.
> Fixed.

LGTM for real this time. :p
Let's see what csharp@ thinks.

[csharp, 2013-05-24 18:37:12]

lgtm

https://chromiumcodereview.appspot.com/16032004/diff/8001/chrome/browser/exte...
File chrome/browser/extensions/extension_sorting.h (right):

https://chromiumcodereview.appspot.com/16032004/diff/8001/chrome/browser/exte...
chrome/browser/extensions/extension_sorting.h:217: // construction when the app
order may not have been deptermined.
Nit: deptermined -> determined

[stevenjb, 2013-05-24 18:40:56]

https://chromiumcodereview.appspot.com/16032004/diff/8001/chrome/browser/exte...
File chrome/browser/extensions/extension_sorting.h (right):

https://chromiumcodereview.appspot.com/16032004/diff/8001/chrome/browser/exte...
chrome/browser/extensions/extension_sorting.h:217: // construction when the app
order may not have been deptermined.
On 2013/05/24 18:37:12, csharp wrote:
> Nit: deptermined -> determined

Done.

[commit-bot: I haz the power, 2013-05-24 18:41:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/16032004/10002

[asargent_no_longer_on_chrome, 2013-05-24 20:38:16]

lgtm

[commit-bot: I haz the power, 2013-05-24 23:42:07]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-05-25 06:26:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/16032004/10002

[commit-bot: I haz the power, 2013-05-26 02:36:19]

Change committed as 202337