chrome/browser/chromeos/extensions/default_app_order.cc - Issue 16032004: Call CreateDefaultOrdinals() when needed, instead of on construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/default_app_order.cc

Issue 16032004: Call CreateDefaultOrdinals() when needed, instead of on construction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix comment Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/default_app_order.cc

diff --git a/chrome/browser/chromeos/extensions/default_app_order.cc b/chrome/browser/chromeos/extensions/default_app_order.cc

index a63df33e4daa6909379c27ead72015af40d245be..7a8551e0ca6e30ce711a80b8cb8bd8fd64db182f 100644

--- a/chrome/browser/chromeos/extensions/default_app_order.cc

+++ b/chrome/browser/chromeos/extensions/default_app_order.cc

@@ -103,7 +103,8 @@ ExternalLoader::~ExternalLoader() {

}

const std::vector<std::string>& ExternalLoader::GetAppIds() {

- CHECK(loaded_.IsSignaled());

+ if (!loaded_.IsSignaled())

+ LOG(ERROR) << "GetAppIds() called before loaded.";

return app_ids_;

}

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_sorting.h » ('j') | no next file with comments »