Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1603063003: [interpreter] Deprecate the --ignition-fake-try-catch flag. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_int-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Deprecate the --ignition-fake-try-catch flag. This removes the above flag definition. The flag is no longer needed as the default implementation is more than capable of faking presence of handling of try-catch and try-finally constructs by now. R=rmcilroy@chromium.org BUG=v8:4674 LOG=n Committed: https://crrev.com/24a8476904c8ff8bcc414cc9e6f87435ce3e99d5 Cr-Commit-Position: refs/heads/master@{#33402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-19 16:48:08 UTC) #1
rmcilroy
lgtm, thanks.
4 years, 11 months ago (2016-01-19 17:10:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603063003/1
4 years, 11 months ago (2016-01-20 11:19:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 11:35:31 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 11:36:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24a8476904c8ff8bcc414cc9e6f87435ce3e99d5
Cr-Commit-Position: refs/heads/master@{#33402}

Powered by Google App Engine
This is Rietveld 408576698