third_party/WebKit/Source/core/css/cssom/LengthValue.h - Issue 1602843003: Update StyleValue.cssString() to use existing methods instead of rolling our own.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/LengthValue.h

Issue 1602843003: Update StyleValue.cssString() to use existing methods instead of rolling our own. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert TransformValue.html Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/KeywordValue.cpp ('k') | third_party/WebKit/Source/core/css/cssom/LengthValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/LengthValue.h

diff --git a/third_party/WebKit/Source/core/css/cssom/LengthValue.h b/third_party/WebKit/Source/core/css/cssom/LengthValue.h

index f3c0326e5d39de47b812c0429d587cbc8bbd6163..24847ec8efee02b63b56b2432147e1d2829cdbe8 100644

--- a/third_party/WebKit/Source/core/css/cssom/LengthValue.h

+++ b/third_party/WebKit/Source/core/css/cssom/LengthValue.h

@@ -50,7 +50,8 @@ protected:

LengthValue() {}

static LengthUnit lengthUnitFromName(const String&);

- static const String& lengthTypeToString(LengthUnit type);

+ static const String& lengthTypeToString(LengthUnit);

+ static CSSPrimitiveValue::UnitType lengthTypeToPrimitiveType(LengthUnit);

virtual LengthValue* addInternal(const LengthValue* other, ExceptionState&);

virtual LengthValue* subtractInternal(const LengthValue* other, ExceptionState&);