Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

Issue 1602773005: Respect break-inside:avoid on table rows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
index bb06c859deda37ce5aeb1dd6e8fd08066c402dc0..d2481caaed5b69b342b9817fc46c14cab8a76727 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
@@ -1643,6 +1643,12 @@ RootInlineBox* LayoutBlockFlow::determineStartPosition(LineLayoutState& layoutSt
LayoutUnit paginationDelta;
for (curr = firstRootBox(); curr && !curr->isDirty(); curr = curr->nextRootBox()) {
if (paginated) {
+ // If a cell's row wants to avoid straddling page breaks then we always need to layout all
+ // the content in the cell at once.
+ if (isTableCell() && toLayoutBox(parent())->getPaginationBreakability() != AllowAnyBreaks) {
mstensho (USE GERRIT) 2016/03/29 09:57:46 This piece of code isn't covered by any test, it s
rhogan 2016/03/29 19:04:36 No - but it is covered by one of my printing tests
rhogan 2016/04/03 14:56:41 Now covered by fast/multicol/cell-doesnt-fit-on-pa
+ layoutState.markForFullLayout();
+ break;
+ }
paginationDelta -= curr->paginationStrut();
adjustLinePositionForPagination(*curr, paginationDelta);
if (paginationDelta) {

Powered by Google App Engine
This is Rietveld 408576698