Respect break-inside:avoid on table rows

third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All right reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 1625 matching lines @@
     RootInlineBox* last = nullptr;
     RootInlineBox* firstLineBoxWithBreakAndClearance = 0;
 
     // FIXME: This entire float-checking block needs to be broken into a new function.
     if (!layoutState.isFullLayout()) {
         // Paginate all of the clean lines.
         bool paginated = view()->layoutState() && view()->layoutState()->isPaginated();
         LayoutUnit paginationDelta;
         for (curr = firstRootBox(); curr && !curr->isDirty(); curr = curr->nextRootBox()) {
             if (paginated) {
+                // If a cell's row wants to avoid straddling page breaks then we always need to layout all
+                // the content in the cell at once.
+                if (isTableCell() && toLayoutBox(parent())->getPaginationBreakability() != AllowAnyBreaks) {

[mstensho (USE GERRIT), 2016/03/29 09:57:46]

This piece of code isn't covered by any test, it seems.

[rhogan, 2016/03/29 19:04:36]

No - but it is covered by one of my printing tests, which is why I want to add
it. I think I have the energy now to rewrite or come up with new ones now - it
was too dispiriting a prospect last time around!

[rhogan, 2016/04/03 14:56:41]

Now covered by fast/multicol/cell-doesnt-fit-on-page-has-text.html

+                    layoutState.markForFullLayout();
+                    break;
+                }
                 paginationDelta -= curr->paginationStrut();
                 adjustLinePositionForPagination(*curr, paginationDelta);
                 if (paginationDelta) {
                     if (containsFloats() || !layoutState.floats().isEmpty()) {
                         // FIXME: Do better eventually.  For now if we ever shift because of pagination and floats are present just go to a full layout.
                         layoutState.markForFullLayout();
                         break;
                     }
 
                     layoutState.updatePaintInvalidationRangeFromBox(curr, paginationDelta);
@@ skipping 451 matching lines @@
     if (!line || !line->isFirstLineStyle())
         return reason;
     // It's the RootInlineBox that paints the ::first-line background. Note that since it may be
     // expensive to figure out if the first line is affected by any ::first-line selectors at all,
     // we just invalidate it unconditionally, since that's typically cheaper.
     invalidateDisplayItemClient(*line);
     return reason;
 }
 
 } // namespace blink