Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 160259: - Bind CanvasPixelArray wrappers to the backing store directly without... (Closed)

Created:
11 years, 5 months ago by iposva
Modified:
9 years, 4 months ago
Reviewers:
Kasper Lund, dglazkov
CC:
v8-dev
Base URL:
http://svn.webkit.org/repository/webkit/trunk/WebCore/
Visibility:
Public.

Description

- Bind CanvasPixelArray wrappers to the backing store directly without the use of an interceptor. Landed upstream by Dimitri as http://trac.webkit.org/changeset/46495

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M bindings/v8/V8DOMWrapper.cpp View 2 chunks +6 lines, -1 line 2 comments Download

Messages

Total messages: 1 (0 generated)
iposva
11 years, 5 months ago (2009-07-28 03:41:57 UTC) #1
This is the minimal change which needs to go into the V8 bindings to start using
the pixel array data in V8. The pixel array support in V8 is being added with
this change list: http://codereview.chromium.org/159263

I am aware that there are more custom functions which can be removed eventually,
but I left them all in for now to be able to switch back to the original code
quickly.

Thanks for your feedback,
-Ivan

http://codereview.chromium.org/160259/diff/1/2
File bindings/v8/V8DOMWrapper.cpp (right):

http://codereview.chromium.org/160259/diff/1/2#newcode295
Line 295:
//descriptor->InstanceTemplate()->SetIndexedPropertyHandler(USE_INDEXED_PROPERTY_GETTER(CanvasPixelArray),
USE_INDEXED_PROPERTY_SETTER(CanvasPixelArray));
This will be removed before commit, but it helps being here to debug for now.

http://codereview.chromium.org/160259/diff/1/2#newcode565
Line 565: result->SetElementsToPixelData(pixels->data()->data(),
pixels->length());
I will change the API call in V8 to SetIndexedPropertiesToPixelData to align the
naming with the rest of the API.

Powered by Google App Engine
This is Rietveld 408576698