- Bind CanvasPixelArray wrappers to the backing store directly without...

bindings/v8/V8DOMWrapper.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * 
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  * 
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 274 matching lines @@
         descriptor->InstanceTemplate()->SetCallAsFunctionHandler(USE_CALLBACK(HTMLPlugInElement));
         break;
     case V8ClassIndex::HTMLFRAMESETELEMENT:
         descriptor->InstanceTemplate()->SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(HTMLFrameSetElement));
         break;
     case V8ClassIndex::HTMLFORMELEMENT:
         descriptor->InstanceTemplate()->SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(HTMLFormElement));
         descriptor->InstanceTemplate()->SetIndexedPropertyHandler(USE_INDEXED_PROPERTY_GETTER(HTMLFormElement), 0, 0, 0, nodeCollectionIndexedPropertyEnumerator<HTMLFormElement>, v8::Integer::New(V8ClassIndex::NODE));
         break;
     case V8ClassIndex::CANVASPIXELARRAY:
-        descriptor->InstanceTemplate()->SetIndexedPropertyHandler(USE_INDEXED_PROPERTY_GETTER(CanvasPixelArray), USE_INDEXED_PROPERTY_SETTER(CanvasPixelArray));
+        //descriptor->InstanceTemplate()->SetIndexedPropertyHandler(USE_INDEXED_PROPERTY_GETTER(CanvasPixelArray), USE_INDEXED_PROPERTY_SETTER(CanvasPixelArray));

[iposva, 2009/07/28 03:41:58]

This will be removed before commit, but it helps being here to debug for now.

         break;
     case V8ClassIndex::STYLESHEET:  // fall through
     case V8ClassIndex::CSSSTYLESHEET: {
         // We add an extra internal field to hold a reference to
         // the owner node.
         v8::Local<v8::ObjectTemplate> instanceTemplate = descriptor->InstanceTemplate();
         ASSERT(instanceTemplate->InternalFieldCount() == V8Custom::kDefaultWrapperInternalFieldCount);
         instanceTemplate->SetInternalFieldCount(V8Custom::kStyleSheetInternalFieldCount);
         break;
     }
@@ skipping 246 matching lines @@
                 DOM_OBJECT_TYPES(MAKE_CASE)
 #undef MAKE_CASE
             default:
                 ASSERT_NOT_REACHED();
             }
             result = v8::Persistent<v8::Object>::New(v8Object);
             if (isActiveDomObject)
                 setJSWrapperForActiveDOMObject(impl, result);
             else
                 setJSWrapperForDOMObject(impl, result);
+              
+            if (type == V8ClassIndex::CANVASPIXELARRAY) {
+              CanvasPixelArray* pixels = reinterpret_cast<CanvasPixelArray*>(impl);
+              result->SetElementsToPixelData(pixels->data()->data(), pixels->length());

[iposva, 2009/07/28 03:41:58]

I will change the API call in V8 to SetIndexedPropertiesToPixelData to align the
naming with the rest of the API.

+            }
 
             // Special case for non-node objects associated with a
             // DOMWindow. Both Safari and FF let the JS wrappers for these
             // objects survive GC. To mimic their behavior, V8 creates
             // hidden references from the DOMWindow to these wrapper
             // objects. These references get cleared when the DOMWindow is
             // reused by a new page.
             switch (type) {
             case V8ClassIndex::CONSOLE:
                 setHiddenWindowReference(static_cast<Console*>(impl)->frame(), V8Custom::kDOMWindowConsoleIndex, result);
@@ skipping 838 matching lines @@
     if (V8IsolatedWorld* world = V8IsolatedWorld::getEntered()) {
        context = world->context();
        if (frame != V8Proxy::retrieveFrame(context))
           return v8::Handle<v8::Context>();
     }
 
     return context;
 }
 
 }  // namespace WebCore