Removed client side support for old sync points.

Removed client side support for old sync points.

R=piman@chromium.org
BUG=514815
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cbda834dc41f646c7ce6c2acff18eca9b6a3047a
Cr-Commit-Position: refs/heads/master@{#370504}

[David Yen, 2016-01-19 22:35:11]

Description was changed from

==========
Removed client side support for old sync points.

R=piman@chromium.org
BUG=514815
==========

to

==========
Removed client side support for old sync points.

R=piman@chromium.org
BUG=514815
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[David Yen, 2016-01-19 22:37:15]

dyen@chromium.org changed reviewers:
+ dcheng@chromium.org, yzshen@chromium.org

[David Yen, 2016-01-19 22:37:16]

+dcheng@ for WebGraphicsContext3D.h review
+yzshen@ for mojo autogen headers review

[yzshen1, 2016-01-19 22:43:25]

mojo auto gen files LGTM

[dcheng, 2016-01-19 22:44:42]

lgtm

[David Yen, 2016-01-19 22:59:01]

dyen@chromium.org changed reviewers:
+ sky@chromium.org

[David Yen, 2016-01-19 22:59:02]

+sky@ for DrawingBufferTest change, the deleted function is not used anymore so
it doesn't change anything.

[sky, 2016-01-19 23:13:02]

On 2016/01/19 22:59:02, David Yen wrote:
> +sky@ for DrawingBufferTest change, the deleted function is not used anymore
so
> it doesn't change anything.

I'm not a webkit owner.

[David Yen, 2016-01-19 23:17:48]

dyen@chromium.org changed reviewers:
+ kbr@chromium.org
- sky@chromium.org

[David Yen, 2016-01-19 23:17:48]

On 2016/01/19 23:13:02, sky wrote:
> On 2016/01/19 22:59:02, David Yen wrote:
> > +sky@ for DrawingBufferTest change, the deleted function is not used anymore
> so
> > it doesn't change anything.
> 
> I'm not a webkit owner.

Strange, looks like your third_party ownership is bleeding through. I'll add
kbr@ instead.

+kbr@ for DrawingBufferTest review, I just removed a function that is not used
anymore.

[Ken Russell (switch to Gerrit), 2016-01-19 23:26:51]

DrawingBufferTest and anything else I'm an owner of LGTM.

[piman, 2016-01-20 01:10:38]

LGTM. Can you also remove CommandBufferNamespace::OLD_SYNC_POINTS, and the
SyncToken(uint32_t sync_point) constructor?

[David Yen, 2016-01-20 18:51:58]

On 2016/01/20 01:10:38, piman (Slow to review) wrote:
> LGTM. Can you also remove CommandBufferNamespace::OLD_SYNC_POINTS, and the
> SyncToken(uint32_t sync_point) constructor?

Looks like some unit tests are still using that, I will create another CL to do
that since the changes are not quite trivial.

[piman, 2016-01-20 18:54:55]

On 2016/01/20 18:51:58, David Yen wrote:
> On 2016/01/20 01:10:38, piman (Slow to review) wrote:
> > LGTM. Can you also remove CommandBufferNamespace::OLD_SYNC_POINTS, and the
> > SyncToken(uint32_t sync_point) constructor?
> 
> Looks like some unit tests are still using that, I will create another CL to
do
> that since the changes are not quite trivial.

Ok, LGTM for this, and remove as a follow-up. I mostly care about removing
OLD_SYNC_POINTS, if an extra constructor is useful for tests, we can leave it.

[David Yen, 2016-01-20 20:09:02]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2016-01-20 20:09:03]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1602313002/#ps20001
(title: "Removed DrawingBufferTest reference")

[commit-bot: I haz the power, 2016-01-20 20:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602313002/20001

[commit-bot: I haz the power, 2016-01-20 21:51:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-20 21:52:12]

Description was changed from

==========
Removed client side support for old sync points.

R=piman@chromium.org
BUG=514815
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Removed client side support for old sync points.

R=piman@chromium.org
BUG=514815
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cbda834dc41f646c7ce6c2acff18eca9b6a3047a
Cr-Commit-Position: refs/heads/master@{#370504}
==========

[commit-bot: I haz the power, 2016-01-20 21:52:13]

Patchset 2 (id:??) landed as
https://crrev.com/cbda834dc41f646c7ce6c2acff18eca9b6a3047a
Cr-Commit-Position: refs/heads/master@{#370504}