Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: tests/html/rtc_test.dart

Issue 16023011: Make RTC work on Firefox (mostly). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/html/rtc_test.dart
diff --git a/tests/html/rtc_test.dart b/tests/html/rtc_test.dart
index d5cf9aade4cc73d137cc95b3b76d64dc173c629f..df096ab01b0da28a1d789c7d32dc0a7de422d167 100644
--- a/tests/html/rtc_test.dart
+++ b/tests/html/rtc_test.dart
@@ -17,16 +17,20 @@ main() {
});
group('functionality', () {
- // TODO(efortuna): More thorough testing of this API requires the user to
+ // More thorough testing of this API requires the user to
// explicitly click "allow this site to access my camera and/or microphone."
// or particularly allow that site to always have those permission on each
- // computer the test is run. Contact WebKit and/or Chrome people to
- // determine how they test with this issue.
+ // computer the test is run. For more through tests, see
+ // interactive_test.dart.
if (RtcPeerConnection.supported) {
test('peer connection', () {
var pc = new RtcPeerConnection(
- {'iceServers': [ {'url':'stun:foo.com:19302'}]});
+ {'iceServers': [ {'url':'stun:216.93.246.18:3478'}]});
expect(pc is RtcPeerConnection, isTrue);
+ // TODO(efortuna): Uncomment this test when RTCPeerConnection correctly
+ // implements EventListener in Firefox (works correctly in nightly, so
+ // it's coming!).
+ //pc.onIceCandidate.listen((candidate) {});
});
test('ice candidate', () {
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | tools/dom/templates/html/dart2js/impl_RTCIceCandidate.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698