Use HTMLElementFactory to create equivalent elements in WebVTTElement.

Use HTMLElementFactory to create equivalent elements in WebVTTElement.

This change forces the calls through the factory so that we create
appropriate sub-classes based upon the passed tag name, rather than
just creating a concrete HTMLElement class with an inappropriate tag
name.

BUG=243881
R=inferno@chromium.org, vcarbune@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151287

[Tom Sepez, 2013-05-24 21:17:29]

@vcarbune, please review.  Thanks.

[vcarbune.chromium, 2013-05-24 21:30:57]

LGTM

Thanks for doing the patch! Would it be worth having the minimized ClusterFuzz
test as well with this change?

[Tom Sepez, 2013-05-24 21:41:57]

>  Would it be worth having the minimized ClusterFuzz
> test as well with this change?
Probably.

[Tom Sepez, 2013-05-24 21:57:28]

@vcarbune - please review the test case added in patch set 2.

[vcarbune.chromium, 2013-05-27 00:16:06]

On 2013/05/24 21:57:28, Tom Sepez wrote:
> @vcarbune - please review the test case added in patch set 2.

LGTM, thanks for adding it!

[commit-bot: I haz the power, 2013-05-27 01:21:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/16019013/5001

[commit-bot: I haz the power, 2013-05-27 01:33:08]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[inferno, 2013-05-28 00:50:59]

lgtm

[commit-bot: I haz the power, 2013-05-28 00:51:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/16019013/5001

[commit-bot: I haz the power, 2013-05-28 02:16:42]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-05-28 02:19:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/16019013/5001

[commit-bot: I haz the power, 2013-05-28 03:44:31]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[inferno, 2013-05-28 05:38:48]

On 2013/05/28 03:44:31, I haz the power (commit-bot) wrote:
> Retried try job too often on mac_layout_rel for step(s) webkit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

Looks like you placed the test expectations file in linux platform specific
directory. That is why it is failing on windows and mac.

[Tom Sepez, 2013-05-28 17:40:23]

Ah, thanks.  Looks like run-webkit-tests on linux puts this in the "wrong"
place.

[commit-bot: I haz the power, 2013-05-28 17:45:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/16019013/33001

[commit-bot: I haz the power, 2013-05-28 19:03:42]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[inferno, 2013-05-28 19:24:46]

Committed patchset #3 manually as r151287 (presubmit successful).