Have gn gen assert that the output directory does not have GYP artifacts

Have gn gen assert that the output directory does not have GYP artifacts

This can often lead to compile errors.

BUG=578862
Committed: https://crrev.com/5915049689627393a3eb8f531f3a361eedcfbce0
Cr-Commit-Position: refs/heads/master@{#370210}

[agrieve, 2016-01-18 21:03:27]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[agrieve, 2016-01-18 21:03:27]

Probably something we can delete once the transition is complete.

[brettw, 2016-01-19 17:54:10]

I don't think this should go in the root build config file. The root one is
processed before everything else, and nothing else happens until this is done.
Putting the exec_script call here means that the rest of the run is serialized
behind it.

Maybe build/config/BUILD.gn?

Please also write a TODO about removing this when GYP is removed?

[agrieve, 2016-01-19 18:02:44]

On 2016/01/19 17:54:10, brettw wrote:
> I don't think this should go in the root build config file. The root one is
> processed before everything else, and nothing else happens until this is done.
> Putting the exec_script call here means that the rest of the run is serialized
> behind it.
> 
> Maybe build/config/BUILD.gn?
> 
> Please also write a TODO about removing this when GYP is removed?

Good thinking. Done and done.

[brettw, 2016-01-19 21:00:06]

lgtm

[agrieve, 2016-01-19 21:22:16]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-01-19 21:23:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1601893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1601893002/20001

[commit-bot: I haz the power, 2016-01-19 22:43:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-19 22:44:06]

Description was changed from

==========
Have gn gen assert that the output directory does not have GYP artifacts

This can often lead to compile errors.

BUG=578862
==========

to

==========
Have gn gen assert that the output directory does not have GYP artifacts

This can often lead to compile errors.

BUG=578862

Committed: https://crrev.com/5915049689627393a3eb8f531f3a361eedcfbce0
Cr-Commit-Position: refs/heads/master@{#370210}
==========

[commit-bot: I haz the power, 2016-01-19 22:44:07]

Patchset 2 (id:??) landed as
https://crrev.com/5915049689627393a3eb8f531f3a361eedcfbce0
Cr-Commit-Position: refs/heads/master@{#370210}

[mdjones, 2016-01-20 02:35:17]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1602393002/ by mdjones@chromium.org.

The reason for reverting is: arm-builder-rel, arm64-builder-rel,
gn-release-builder-l consistently fail the assertion added in this change..