Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: build/config/BUILD.gn

Issue 1601893002: Have gn gen assert that the output directory does not have GYP artifacts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to build/config/BUILD.gn Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/features.gni") 9 import("//build/config/features.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
11 import("//build/config/ui.gni") 11 import("//build/config/ui.gni")
12 import("//build/toolchain/goma.gni") 12 import("//build/toolchain/goma.gni")
13 13
14 # One common error that happens is that GYP-generated headers within gen/ get
15 # included rather than the GN-generated ones within gen/ subdirectories.
16 # TODO(agrieve): Remove once GYP is gone (as well as exec_script exception).
17 assert(
18 exec_script("//build/dir_exists.py", [ "obj.host" ], "string") == "False",
19 "GYP artifacts detected in $root_build_dir.$0x0A" +
20 "You must wipe this directory before building with GN.")
21
14 declare_args() { 22 declare_args() {
15 # When set (the default) enables C++ iterator debugging in debug builds. 23 # When set (the default) enables C++ iterator debugging in debug builds.
16 # Iterator debugging is always off in release builds (technically, this flag 24 # Iterator debugging is always off in release builds (technically, this flag
17 # affects the "debug" config, which is always available but applied by 25 # affects the "debug" config, which is always available but applied by
18 # default only in debug builds). 26 # default only in debug builds).
19 # 27 #
20 # Iterator debugging is generally useful for catching bugs. But it can 28 # Iterator debugging is generally useful for catching bugs. But it can
21 # introduce extra locking to check the state of an iterator against the state 29 # introduce extra locking to check the state of an iterator against the state
22 # of the current object. For iterator- and thread-heavy code, this can 30 # of the current object. For iterator- and thread-heavy code, this can
23 # significantly slow execution. 31 # significantly slow execution.
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 # This error doesn't happen every time. In VS2013, it seems if the .pch 483 # This error doesn't happen every time. In VS2013, it seems if the .pch
476 # file doesn't exist, no error will be generated (probably MS tested this 484 # file doesn't exist, no error will be generated (probably MS tested this
477 # case but forgot the other one?). To reproduce this error, do a build, 485 # case but forgot the other one?). To reproduce this error, do a build,
478 # then delete the precompile.c.obj file, then build again. 486 # then delete the precompile.c.obj file, then build again.
479 cflags_c = [ "/wd4206" ] 487 cflags_c = [ "/wd4206" ]
480 } else if (is_mac && !is_official_build && !use_goma) { 488 } else if (is_mac && !is_official_build && !use_goma) {
481 precompiled_header = "build/precompile.h" 489 precompiled_header = "build/precompile.h"
482 precompiled_source = "//build/precompile.h" 490 precompiled_source = "//build/precompile.h"
483 } 491 }
484 } 492 }
OLDNEW
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698