Issue 16018004: Clean up after moving ProfileKeyedService files to a component.

Issue 16018004: Clean up after moving ProfileKeyedService files to a component. (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.

Modified:
7 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit), Jói

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up after moving ProfileKeyedService files to a component. BUG=227219 R=jochen@chromium.org, joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202466

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -25 lines)			Patch
M	chrome/browser/bookmarks/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/favicon/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/google_apis/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/history/DEPS	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/signin/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/test/base/testing_profile.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/testing_profile.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Please review: Jói: full review Jochen: chrome OWNERS

7 years, 7 months ago (2013-05-27 20:55:45 UTC) #1

Paweł Hajdan Jr.

Committed patchset #1 manually as r202466 (presubmit successful).

7 years, 7 months ago (2013-05-27 21:37:57 UTC) #4

tfarina

On 2013/05/27 21:04:58, Jói wrote: > LGTM Joi, looks like you forgot that I have ...

7 years, 6 months ago (2013-05-29 01:04:31 UTC) #5

Jói

7 years, 6 months ago (2013-05-29 10:57:18 UTC) #6

Doh, sorry about that Thiago! I remember thinking "oh good, more DEPS
cleanup like Thiago did the other day" but I didn't realize it was
actually a duplicate.

On Wed, May 29, 2013 at 2:04 AM,  <tfarina@chromium.org> wrote:
> On 2013/05/27 21:04:58, Jói wrote:
>>
>> LGTM
>
>
> Joi, looks like you forgot that I have actually did this!
>
> Sigh!
>
> https://codereview.chromium.org/16072002/
>
> https://codereview.chromium.org/16018004/

Expand Messages | Collapse Messages