Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: chrome/browser/favicon/DEPS

Issue 16018004: Clean up after moving ProfileKeyedService files to a component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/bookmarks/DEPS ('k') | chrome/browser/google_apis/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Favicon is being made into a Browser Component, so we have these 2 # Favicon is being made into a Browser Component, so we have these
3 # three basic rules followed by temporary exceptions. Please don't 3 # three basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/api", 6 "+chrome/browser/api",
7 "+chrome/browser/common", 7 "+chrome/browser/common",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 9
10 # Permanently-allowed DEPS beyond the standard Browser 10 # Permanently-allowed DEPS beyond the standard Browser
11 # Components-like DEPS above go here. 11 # Components-like DEPS above go here.
12 "+chrome/browser/search/search.h", 12 "+chrome/browser/search/search.h",
13 "+third_party/skia/include/core/SkBitmap.h", 13 "+third_party/skia/include/core/SkBitmap.h",
14 14
15 # TODO(caitkp): Bring this list to zero. 15 # TODO(caitkp): Bring this list to zero.
16 # 16 #
17 # Do not add to the list of temporarily-allowed dependencies below, 17 # Do not add to the list of temporarily-allowed dependencies below,
18 # and please do not introduce more #includes of these files. 18 # and please do not introduce more #includes of these files.
19 "!chrome/browser/bookmarks/bookmark_service.h", 19 "!chrome/browser/bookmarks/bookmark_service.h",
20 "!chrome/browser/history/history_backend.h", 20 "!chrome/browser/history/history_backend.h",
21 "!chrome/browser/history/history_service.h", 21 "!chrome/browser/history/history_service.h",
22 "!chrome/browser/history/history_service_factory.h", 22 "!chrome/browser/history/history_service_factory.h",
23 "!chrome/browser/history/select_favicon_frames.h", 23 "!chrome/browser/history/select_favicon_frames.h",
24 "!chrome/browser/profiles/profile.h", 24 "!chrome/browser/profiles/profile.h",
25 "!chrome/browser/profiles/profile_dependency_manager.h",
26 "!chrome/browser/profiles/profile_keyed_service.h",
27 "!chrome/browser/profiles/profile_keyed_service_factory.h",
28 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h", 25 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h",
29 # Do not add to the list of temporarily-allowed dependencies above, 26 # Do not add to the list of temporarily-allowed dependencies above,
30 # and please do not introduce more #includes of these files. 27 # and please do not introduce more #includes of these files.
31 ] 28 ]
32 29
33 specific_include_rules = { 30 specific_include_rules = {
34 # TODO(caitkp): Look into removing history/ dependencies. 31 # TODO(caitkp): Look into removing history/ dependencies.
35 'favicon_util\.(h|cc)': [ 32 'favicon_util\.(h|cc)': [
36 "-chrome", 33 "-chrome",
37 "-chrome/browser", 34 "-chrome/browser",
38 "+chrome/browser/favicon/favicon_types.h", 35 "+chrome/browser/favicon/favicon_types.h",
39 "+chrome/browser/favicon/favicon_util.h", 36 "+chrome/browser/favicon/favicon_util.h",
40 "+chrome/common/icon_messages.h", 37 "+chrome/common/icon_messages.h",
41 "!chrome/browser/history/history_types.h", 38 "!chrome/browser/history/history_types.h",
42 "!chrome/browser/history/select_favicon_frames.h", 39 "!chrome/browser/history/select_favicon_frames.h",
43 ] 40 ]
44 } 41 }
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/DEPS ('k') | chrome/browser/google_apis/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698