Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1601743010: NaCl: Update revision in DEPS, 26c7e6a -> d8cbca8 (Closed)

Created:
4 years, 11 months ago by Derek Schuff
Modified:
4 years, 11 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, erikchen, Roland McGrath, native-client-reviews_googlegroups.com, petarj, Jim Stichnoth, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, 26c7e6a -> d8cbca8 This pulls in the following Native Client changes: 95163bf: (stichnot@chromium.org) Update revision for PNaCl abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO aebc3c4: (mcgrathr@chromium.org) Update chrome_rev c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. 6c30fab: (sbc@chromium.org) untrusted.gypi: Remove support for old gcc newlib toolchain dd69634: (stichnot@chromium.org) Subzero: Add pnacl-translate support for Subzero+NonSFI+x8632. 2d5bba1: (dschuff@chromium.org) [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac bdd3ffa: (dschuff@chromium.org) Revert of [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac (patchset #2 id:20001 of https://codereview.chromium.org/1586243003/ ) a52204c: (dschuff@chromium.org) Revert of [PNaCl toolchain] Stop building and using custom libc++ for OSX hosts (patchset #2 id:20001 of https://codereview.chromium.org/1572753002/ ) 7f31837: (dschuff@chromium.org) PNaCl toolchain: Add 'nostdinc++' to build of host tools against libc++ d8cbca8: (dschuff@chromium.org) Update revision for PNaCl Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6ae1327a43c948f4666fef9e84fe351ab7c..d8cbca85d544fd5d1469a8017bbf4d9136bfff5e BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build Committed: https://crrev.com/e5443f9b47b2474bebc8989b35b0182bfc191c89 Cr-Commit-Position: refs/heads/master@{#370548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
Derek Schuff
Here's a manual roll. The bots won't pass until goma gets the updated compiler, which ...
4 years, 11 months ago (2016-01-20 21:41:53 UTC) #3
Mark Seaborn
Auto-LGTM, thanks
4 years, 11 months ago (2016-01-20 21:50:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601743010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601743010/1
4 years, 11 months ago (2016-01-20 22:55:10 UTC) #7
Derek Schuff
On 2016/01/20 22:55:10, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 11 months ago (2016-01-20 23:00:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 00:41:10 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5443f9b47b2474bebc8989b35b0182bfc191c89 Cr-Commit-Position: refs/heads/master@{#370548}
4 years, 11 months ago (2016-01-21 00:42:35 UTC) #12
sgurun-gerrit only
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1611663003/ by sgurun@chromium.org. ...
4 years, 11 months ago (2016-01-21 01:26:49 UTC) #13
Mark Seaborn
On 20 January 2016 at 17:26, <sgurun@chromium.org> wrote: > A revert of this CL (patchset ...
4 years, 11 months ago (2016-01-21 02:21:55 UTC) #14
Mark Seaborn
On 20 January 2016 at 17:26, <sgurun@chromium.org> wrote: > A revert of this CL (patchset ...
4 years, 11 months ago (2016-01-21 02:21:56 UTC) #15
Mark Seaborn
On 20 January 2016 at 18:21, Mark Seaborn <mseaborn@chromium.org> wrote: > On 20 January 2016 ...
4 years, 11 months ago (2016-01-21 19:36:41 UTC) #16
Mark Seaborn
On 20 January 2016 at 18:21, Mark Seaborn <mseaborn@chromium.org> wrote: > On 20 January 2016 ...
4 years, 11 months ago (2016-01-21 19:36:44 UTC) #17
Sam Clegg
4 years, 11 months ago (2016-01-21 20:13:38 UTC) #18
Message was sent while issue was closed. 
On 2016/01/21 19:36:44, Mark Seaborn wrote:
> On 20 January 2016 at 18:21, Mark Seaborn <mailto:mseaborn@chromium.org>
wrote:
> 
> > On 20 January 2016 at 17:26, <mailto:sgurun@chromium.org> wrote:
> >
> >> A revert of this CL (patchset #1 id:1) has been created in
> >> https://codereview.chromium.org/1611663003/ by mailto:sgurun@chromium.org.
> >>
> >> The reason for reverting is: due to build break in
> >>
> >>
>
https://build.chromium.org/p/chromium.win/waterfall?builder=Win%20x64%20Build...
> >
> >
> > Specifically, there was the following compile failure:
> >
> > FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool
> > action-wrapper environment.x64
> >
>
ppapi_tests_extensions_no_socket_permissions_target_build_newlib_x86_64_nexe_ff49b755b038c2b39cc59644a35b7542..rsp
> > ..\..\ppapi\tests\extensions
> > Assembler messages:
> >
> > Fatal error: can't create
> >
>
../../../out/Debug_x64/obj/ppapi/tests/extensions/ppapi_tests_extensions_no_socket_permissions.gen/newlib-x86-64/ppapi_tests_extensions_no_socket_permissions/test_no_socket_permissions_d6663889.o:
> > No such file or directory
> >
> 
> From this error, it looks like the directory
> ".../newlib-x86-64/ppapi_tests_extensions_no_socket_permissions" doesn't
> exist at this point.
> 
> That directory is supposed to get created by build_nexe.py's MakeDir() call
> in Compile().  Maybe there is some problem where build_nexe.py has a
> different idea about parsing Windows filenames than nacl-clang has, such
> that they use slightly different directory names.

Indeed it seems very strange, since the MakeDir() always happens right before
the compiler call.

> 
> Since this occurs for the "newlib-x86-64" directory, it looks related to
> your change, Sam.
> 
> 
> 
> > Linker options: ['-B..\\..\\..\\out\\Debug_x64/gen/tc_newlib/lib64',
> > '-L..\\..\\..\\out\\Debug_x64/gen/tc_newlib/lib64', '-lppapi_cpp',
> > '-lppapi', '-pthread']
> >
> > Skipping unknown type  for .
> >
> 
> This "Skipping unknown type" warning looks odd, but I think it's just an
> artefact of how the "--source-list" file is parsed.  There must be an empty
> filename in the resulting list, which normally just gets ignored.

Yes,  I tracked this down yesterday.  That seems to be unrelated and is a result
of an empty line in the source list (gypcmd) file.  Was going to fix it but
figured its not worth the effort given that gyp is on the way out.

> 
> Cheers,
> Mark
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698