Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1581193006: untrusted.gypi: Remove support for old gcc newlib toolchain (Closed)

Created:
4 years, 11 months ago by Sam Clegg
Modified:
4 years, 11 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

untrusted.gypi: Remove support for old gcc newlib toolchain build_nexe.py can also be simplified but I'll leave that for a subsequent CL. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4352 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/6c30fab49ef4e53b2f59353d59c3f9a7c5b21875

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -24 lines) Patch
M build/untrusted.gypi View 1 11 chunks +11 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Sam Clegg
4 years, 11 months ago (2016-01-14 20:20:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581193006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581193006/20001
4 years, 11 months ago (2016-01-14 20:33:55 UTC) #5
Roland McGrath
lgtm
4 years, 11 months ago (2016-01-14 20:35:07 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 21:08:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581193006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581193006/20001
4 years, 11 months ago (2016-01-15 18:30:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/native_client/src/native_client/+/6c30fab49ef4e53b2f59353d59c3f9a7c5b21875
4 years, 11 months ago (2016-01-15 18:32:32 UTC) #12
Mark Seaborn
It looks like this change caused the following DEPS roll to be reverted, though I'm ...
4 years, 11 months ago (2016-01-21 02:22:34 UTC) #13
Sam Clegg
On 2016/01/21 02:22:34, Mark Seaborn wrote: > It looks like this change caused the following ...
4 years, 11 months ago (2016-01-21 02:30:45 UTC) #14
Mark Seaborn
4 years, 11 months ago (2016-01-21 03:05:55 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1613603002/ by mseaborn@chromium.org.

The reason for reverting is: This seems to have caused a build failure on
Windows when rolled into Chromium (see
https://codereview.chromium.org/1601743010/)..

Powered by Google App Engine
This is Rietveld 408576698