Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: third_party/WebKit/Source/core/page/EventSourceTest.cpp

Issue 1601553004: [EventSource] retry field including non-digit chars should be ignored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event-source
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/EventSourceTest.cpp
diff --git a/third_party/WebKit/Source/core/page/EventSourceTest.cpp b/third_party/WebKit/Source/core/page/EventSourceTest.cpp
index 147e9b4de4dece89e3f7f03a5782f3da03cdd8a1..f32a6b56d2f8bb03678ab812a77daf5f02fa581b 100644
--- a/third_party/WebKit/Source/core/page/EventSourceTest.cpp
+++ b/third_party/WebKit/Source/core/page/EventSourceTest.cpp
@@ -251,29 +251,19 @@ TEST_F(EventSourceTest, NonDigitRetryShouldBeIgnored)
EXPECT_EQ(123u, source()->reconnectDelayForTest());
enqueue("retry:2a\n");
- // TODO(yhirano): Should be ignored.
- // EXPECT_EQ(123u, source()->reconnectDelayForTest());
- EXPECT_EQ(2u, source()->reconnectDelayForTest());
+ EXPECT_EQ(123u, source()->reconnectDelayForTest());
enqueue("retry:09a\n");
- // TODO(yhirano): Should be ignored.
- // EXPECT_EQ(123u, source()->reconnectDelayForTest());
- EXPECT_EQ(9u, source()->reconnectDelayForTest());
+ EXPECT_EQ(123u, source()->reconnectDelayForTest());
enqueue("retry:1\b\n");
- // TODO(yhirano): Should be ignored.
- // EXPECT_EQ(123u, source()->reconnectDelayForTest());
- EXPECT_EQ(1u, source()->reconnectDelayForTest());
+ EXPECT_EQ(123u, source()->reconnectDelayForTest());
enqueue("retry: 1234\n");
- // TODO(yhirano): Should be ignored.
- // EXPECT_EQ(123u, source()->reconnectDelayForTest());
- EXPECT_EQ(1234u, source()->reconnectDelayForTest());
+ EXPECT_EQ(123u, source()->reconnectDelayForTest());
enqueue("retry:456 \n");
- // TODO(yhirano): Should be ignored.
- // EXPECT_EQ(123u, source()->reconnectDelayForTest());
- EXPECT_EQ(456u, source()->reconnectDelayForTest());
+ EXPECT_EQ(123u, source()->reconnectDelayForTest());
EXPECT_EQ(0u, listener->events().size());
}

Powered by Google App Engine
This is Rietveld 408576698