Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: third_party/WebKit/Source/core/page/EventSourceTest.cpp

Issue 1601553004: [EventSource] retry field including non-digit chars should be ignored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event-source
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/page/EventSource.h" 5 #include "core/page/EventSource.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/ScriptValue.h" 9 #include "bindings/core/v8/ScriptValue.h"
10 #include "bindings/core/v8/SerializedScriptValue.h" 10 #include "bindings/core/v8/SerializedScriptValue.h"
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 EXPECT_NE(EventSource::defaultReconnectDelay, source()->reconnectDelayForTes t()); 244 EXPECT_NE(EventSource::defaultReconnectDelay, source()->reconnectDelayForTes t());
245 EXPECT_EQ(123u, source()->reconnectDelayForTest()); 245 EXPECT_EQ(123u, source()->reconnectDelayForTest());
246 246
247 EXPECT_EQ(123u, source()->reconnectDelayForTest()); 247 EXPECT_EQ(123u, source()->reconnectDelayForTest());
248 enqueue("retry:a0\n"); 248 enqueue("retry:a0\n");
249 EXPECT_EQ(123u, source()->reconnectDelayForTest()); 249 EXPECT_EQ(123u, source()->reconnectDelayForTest());
250 enqueue("retry:xi\n"); 250 enqueue("retry:xi\n");
251 EXPECT_EQ(123u, source()->reconnectDelayForTest()); 251 EXPECT_EQ(123u, source()->reconnectDelayForTest());
252 252
253 enqueue("retry:2a\n"); 253 enqueue("retry:2a\n");
254 // TODO(yhirano): Should be ignored. 254 EXPECT_EQ(123u, source()->reconnectDelayForTest());
255 // EXPECT_EQ(123u, source()->reconnectDelayForTest());
256 EXPECT_EQ(2u, source()->reconnectDelayForTest());
257 255
258 enqueue("retry:09a\n"); 256 enqueue("retry:09a\n");
259 // TODO(yhirano): Should be ignored. 257 EXPECT_EQ(123u, source()->reconnectDelayForTest());
260 // EXPECT_EQ(123u, source()->reconnectDelayForTest());
261 EXPECT_EQ(9u, source()->reconnectDelayForTest());
262 258
263 enqueue("retry:1\b\n"); 259 enqueue("retry:1\b\n");
264 // TODO(yhirano): Should be ignored. 260 EXPECT_EQ(123u, source()->reconnectDelayForTest());
265 // EXPECT_EQ(123u, source()->reconnectDelayForTest());
266 EXPECT_EQ(1u, source()->reconnectDelayForTest());
267 261
268 enqueue("retry: 1234\n"); 262 enqueue("retry: 1234\n");
269 // TODO(yhirano): Should be ignored. 263 EXPECT_EQ(123u, source()->reconnectDelayForTest());
270 // EXPECT_EQ(123u, source()->reconnectDelayForTest());
271 EXPECT_EQ(1234u, source()->reconnectDelayForTest());
272 264
273 enqueue("retry:456 \n"); 265 enqueue("retry:456 \n");
274 // TODO(yhirano): Should be ignored. 266 EXPECT_EQ(123u, source()->reconnectDelayForTest());
275 // EXPECT_EQ(123u, source()->reconnectDelayForTest());
276 EXPECT_EQ(456u, source()->reconnectDelayForTest());
277 267
278 EXPECT_EQ(0u, listener->events().size()); 268 EXPECT_EQ(0u, listener->events().size());
279 } 269 }
280 270
281 TEST_F(EventSourceTest, UnrecognizedFieldShouldBeIgnored) 271 TEST_F(EventSourceTest, UnrecognizedFieldShouldBeIgnored)
282 { 272 {
283 RefPtrWillBeRawPtr<FakeEventListener> listener = FakeEventListener::create() ; 273 RefPtrWillBeRawPtr<FakeEventListener> listener = FakeEventListener::create() ;
284 274
285 source()->addEventListener("message", listener); 275 source()->addEventListener("message", listener);
286 enqueue("data:hello\nhoge:fuga\npiyo\n\n"); 276 enqueue("data:hello\nhoge:fuga\npiyo\n\n");
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 ASSERT_EQ("message", messageListener->events()[0]->type()); 396 ASSERT_EQ("message", messageListener->events()[0]->type());
407 RefPtrWillBeRawPtr<MessageEvent> messageEvent = static_cast<MessageEvent*>(m essageListener->events()[0].get()); 397 RefPtrWillBeRawPtr<MessageEvent> messageEvent = static_cast<MessageEvent*>(m essageListener->events()[0].get());
408 ASSERT_EQ(MessageEvent::DataTypeSerializedScriptValue, messageEvent->dataTyp e()); 398 ASSERT_EQ(MessageEvent::DataTypeSerializedScriptValue, messageEvent->dataTyp e());
409 EXPECT_EQ("bye", dataAsString(scriptState(), messageEvent.get())); 399 EXPECT_EQ("bye", dataAsString(scriptState(), messageEvent.get()));
410 EXPECT_EQ("8", messageEvent->lastEventId()); 400 EXPECT_EQ("8", messageEvent->lastEventId());
411 } 401 }
412 402
413 } // namespace 403 } // namespace
414 404
415 } // namespace blink 405 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698