Issue 160143002: Hook up more GN toolkit and UI-based flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160143002: Hook up more GN toolkit and UI-based flags. (Closed)

Created:
6 years, 10 months ago by brettw

Modified:
6 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Hook up more GN toolkit and UI-based flags. This renames the hack "my_msvs" project to "feature_flags" and creates an include file that gives the proper definitions of most of the UI-related feature and OS flags. Hook these flags up the build. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250692

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -39 lines)			Patch
M	base/BUILD.gn	View	5 chunks	+38 lines, -15 lines	0 comments	Download
M	base/test/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	build/config/BUILD.gn	View	3 chunks	+26 lines, -6 lines	0 comments	Download
M	build/config/BUILDCONFIG.gn	View	4 chunks	+1 line, -16 lines	0 comments	Download
M	build/config/linux/BUILD.gn	View	2 chunks	+0 lines, -2 lines	0 comments	Download
A	build/config/ui.gni	View	1 chunk	+61 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/chrome/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/160143002/1

6 years, 10 months ago (2014-02-12 05:21:34 UTC) #4

Message was sent while issue was closed.

Change committed as 250692

Expand Messages | Collapse Messages