Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 160143002: Hook up more GN toolkit and UI-based flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | build/config/linux/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 44c7a315e0f2c7616fa6f98f6064fbb88296352d..34e3a570e7393972338a3555c98e8f114a10e8b7 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -33,16 +33,6 @@ declare_args() {
# to configure warnings.
is_clang = false
- # ASH is enabled.
- # TODO(brettw) this should be moved out of the main build config file.
- use_ash = false
- # Aura is enabled.
- # TODO(brettw) this should be moved out of the main build config file.
- use_aura = false
- # Ozone is enabled.
- # TODO(brettw) this should be moved out of the main build config file.
- use_ozone = false
-
# Forces a 64-bit build on Windows. Does nothing on other platforms. Normally
# we build 32-bit on Windows regardless of the current host OS bit depth.
# Setting this flag will override this logic and generate 64-bit toolchains.
@@ -112,9 +102,6 @@ if (os == "win") {
is_nacl = false
is_posix = false
is_win = true
-
- # Windows currelty implies Aura.
- use_aura = true
} else if (os == "mac") {
is_android = false
is_chromeos = false
@@ -312,8 +299,6 @@ if (!is_clang && (is_asan || is_lsan || is_tsan || is_msan)) {
is_clang = true
}
-toolkit_uses_gtk = is_linux
-
# =============================================================================
# TARGET DEFAULTS
# =============================================================================
@@ -326,7 +311,7 @@ toolkit_uses_gtk = is_linux
# Holds all configs used for making native executables and libraries, to avoid
# duplication in each target below.
native_compiler_configs = [
- "//build/config:my_msvs", # TODO(brettw) eraseme
+ "//build/config:feature_flags",
"//build/config/compiler:compiler",
"//build/config/compiler:chromium_code",
« no previous file with comments | « build/config/BUILD.gn ('k') | build/config/linux/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698