Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: third_party/WebKit/Source/core/inspector/ScriptCallStack.h

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ScriptCallStack.h
diff --git a/third_party/WebKit/Source/core/inspector/ScriptCallStack.h b/third_party/WebKit/Source/core/inspector/ScriptCallStack.h
index f9ca0fa1797701ef2191d02aac597ef1f375f784..a71a3edddb93b9383bac94266248affd236e05e3 100644
--- a/third_party/WebKit/Source/core/inspector/ScriptCallStack.h
+++ b/third_party/WebKit/Source/core/inspector/ScriptCallStack.h
@@ -34,7 +34,6 @@
#include "core/CoreExport.h"
#include "core/InspectorTypeBuilder.h"
#include "core/inspector/ScriptCallFrame.h"
-#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/RefCounted.h"
#include "wtf/Vector.h"
@@ -44,30 +43,28 @@ namespace blink {
class ScriptAsyncCallStack;
class TracedValue;
-class CORE_EXPORT ScriptCallStack final : public RefCountedWillBeGarbageCollectedFinalized<ScriptCallStack> {
+class CORE_EXPORT ScriptCallStack final : public RefCounted<ScriptCallStack> {
public:
static const size_t maxCallStackSizeToCapture = 200;
- static PassRefPtrWillBeRawPtr<ScriptCallStack> create(Vector<ScriptCallFrame>&);
+ static PassRefPtr<ScriptCallStack> create(Vector<ScriptCallFrame>&);
~ScriptCallStack();
const ScriptCallFrame &at(size_t) const;
size_t size() const;
- PassRefPtrWillBeRawPtr<ScriptAsyncCallStack> asyncCallStack() const;
- void setAsyncCallStack(PassRefPtrWillBeRawPtr<ScriptAsyncCallStack>);
+ PassRefPtr<ScriptAsyncCallStack> asyncCallStack() const;
+ void setAsyncCallStack(PassRefPtr<ScriptAsyncCallStack>);
PassRefPtr<TypeBuilder::Array<TypeBuilder::Console::CallFrame> > buildInspectorArray() const;
void toTracedValue(TracedValue*, const char* name) const;
- DECLARE_TRACE();
-
private:
explicit ScriptCallStack(Vector<ScriptCallFrame>&);
Vector<ScriptCallFrame> m_frames;
- RefPtrWillBeMember<ScriptAsyncCallStack> m_asyncCallStack;
+ RefPtr<ScriptAsyncCallStack> m_asyncCallStack;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698