Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.cpp

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.cpp b/third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.cpp
index 154b60e9fa157b59853c751244e067d68c3f63b0..8ec956e75f4a09fcd39b5c7c3fbae3480e3d8731 100644
--- a/third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.cpp
+++ b/third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.cpp
@@ -6,12 +6,12 @@
namespace blink {
-PassRefPtrWillBeRawPtr<ScriptAsyncCallStack> ScriptAsyncCallStack::create(const String& description, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack, PassRefPtrWillBeRawPtr<ScriptAsyncCallStack> asyncStackTrace)
+PassRefPtr<ScriptAsyncCallStack> ScriptAsyncCallStack::create(const String& description, PassRefPtr<ScriptCallStack> callStack, PassRefPtr<ScriptAsyncCallStack> asyncStackTrace)
{
- return adoptRefWillBeNoop(new ScriptAsyncCallStack(description, callStack, asyncStackTrace));
+ return adoptRef(new ScriptAsyncCallStack(description, callStack, asyncStackTrace));
}
-ScriptAsyncCallStack::ScriptAsyncCallStack(const String& description, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack, PassRefPtrWillBeRawPtr<ScriptAsyncCallStack> asyncStackTrace)
+ScriptAsyncCallStack::ScriptAsyncCallStack(const String& description, PassRefPtr<ScriptCallStack> callStack, PassRefPtr<ScriptAsyncCallStack> asyncStackTrace)
: m_description(description)
, m_callStack(callStack)
, m_asyncStackTrace(asyncStackTrace)
@@ -34,10 +34,4 @@ PassRefPtr<TypeBuilder::Console::AsyncStackTrace> ScriptAsyncCallStack::buildIns
return result.release();
}
-DEFINE_TRACE(ScriptAsyncCallStack)
-{
- visitor->trace(m_callStack);
- visitor->trace(m_asyncStackTrace);
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698