third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.h ('K') | « third_party/WebKit/Source/core/frame/ConsoleBase.cpp ('k') | third_party/WebKit/Source/core/frame/FrameConsole.h » ('j') | third_party/WebKit/Source/core/frame/FrameConsole.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index 2a86da71d221ddebc047a2fb71340e0eb8a77c9a..bd2ed6e4e6707df57e94aee584a4c3da686036eb 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -218,7 +218,7 @@ void DOMWindow::postMessage(PassRefPtr<SerializedScriptValue> message, const Mes

bool didHandleMessageEvent = frame()->client()->willCheckAndDispatchMessageEvent(target.get(), event.get(), source->document()->frame());

if (!didHandleMessageEvent) {

// Capture stack trace only when inspector front-end is loaded as it may be time consuming.

- RefPtrWillBeRawPtr<ScriptCallStack> stackTrace = nullptr;

+ RefPtr<ScriptCallStack> stackTrace = nullptr;

if (InspectorInstrumentation::consoleAgentEnabled(sourceDocument))

stackTrace = currentScriptCallStack(ScriptCallStack::maxCallStackSizeToCapture);