third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.h - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.h

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameConsole.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.h

index 0f6126dc606f34ccd3272a0bca2f320bd213e9e0..6779ae99fac21b6f6b0311bf102dd33ebb112eba 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStackFactory.h

@@ -33,6 +33,7 @@

#include "core/CoreExport.h"

#include "core/inspector/ScriptCallStack.h"

+#include "platform/heap/Handle.h"

sof 2016/01/20 11:39:49 If we didn't need it before, won't need it now?

pfeldman 2016/01/20 17:53:28 We used to transitively get it from the ScriptCall

#include "wtf/Forward.h"

#include <v8.h>

@@ -49,9 +50,9 @@ const v8::StackTrace::StackTraceOptions stackTraceOptions = static_cast<v8::Stac

| v8::StackTrace::kScriptNameOrSourceURL

| v8::StackTrace::kFunctionName);

-PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(v8::Isolate*, v8::Local<v8::StackTrace>, size_t maxStackSize);

-CORE_EXPORT PassRefPtrWillBeRawPtr<ScriptCallStack> currentScriptCallStack(size_t maxStackSize);

-PassRefPtrWillBeRawPtr<ScriptCallStack> currentScriptCallStackForConsole(size_t maxStackSize = ScriptCallStack::maxCallStackSizeToCapture);

+PassRefPtr<ScriptCallStack> createScriptCallStack(v8::Isolate*, v8::Local<v8::StackTrace>, size_t maxStackSize);

+CORE_EXPORT PassRefPtr<ScriptCallStack> currentScriptCallStack(size_t maxStackSize);

+PassRefPtr<ScriptCallStack> currentScriptCallStackForConsole(size_t maxStackSize = ScriptCallStack::maxCallStackSizeToCapture);

PassRefPtrWillBeRawPtr<ScriptArguments> createScriptArguments(ScriptState*, const v8::FunctionCallbackInfo<v8::Value>& v8arguments, unsigned skipArgumentCount);

} // namespace blink