Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1601223003: S390: Add platform specific atomic ops impl (Closed)

Created:
4 years, 11 months ago by JoranSiu
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Add platform specific atomic ops impl Add S390 specific atomic ops implementation + associated build toolchain updates. R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com BUG= Committed: https://crrev.com/4cbd63c9bfee2b734f67f5bd36b98dcab072021f Cr-Commit-Position: refs/heads/master@{#33519}

Patch Set 1 #

Patch Set 2 : Update header #define macro for consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -26 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/base/atomicops.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/base/atomicops_internals_s390_gcc.h View 1 6 chunks +10 lines, -26 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
JoranSiu
Add S390 specific implementation to the various atomic ops functions.
4 years, 11 months ago (2016-01-19 17:52:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601223003/20001
4 years, 11 months ago (2016-01-20 23:01:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 23:22:17 UTC) #7
john.yan
lgtm
4 years, 11 months ago (2016-01-21 19:08:03 UTC) #8
michael_dawson
On 2016/01/21 19:08:03, john.yan wrote: > lgtm lgtm
4 years, 11 months ago (2016-01-25 22:17:55 UTC) #9
Jakob Kummerow
LGTM. Sorry for the delay on this one. Sven doesn't work on V8 any more. ...
4 years, 11 months ago (2016-01-26 14:10:53 UTC) #11
JoranSiu
On 2016/01/26 14:10:53, Jakob wrote: > LGTM. > > Sorry for the delay on this ...
4 years, 11 months ago (2016-01-26 14:22:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601223003/20001
4 years, 11 months ago (2016-01-26 14:22:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 14:48:29 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 14:49:31 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4cbd63c9bfee2b734f67f5bd36b98dcab072021f
Cr-Commit-Position: refs/heads/master@{#33519}

Powered by Google App Engine
This is Rietveld 408576698