Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: build/common.gypi

Issue 160113002: Exclude notification strings for builds that dont use it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/app/generated_resources.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 07a420b950fa4df2fe0cf7915b5ae39da6894b61..abff975f1ae6748a5e557d8b4c0657840a31dffa 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -616,6 +616,9 @@
'native_memory_pressure_signals%': 1,
'enable_printing%': 2,
'enable_task_manager%':0,
+ # Set to 1 once we have a notification system for Android.
+ # http://crbug.com/115320
+ 'notifications%': 0,
}],
# Android OS includes support for proprietary codecs regardless of
@@ -1463,10 +1466,6 @@
# Sessions are store separately in the Java side.
'enable_session_service%': 0,
- # Set to 1 once we have a notification system for Android.
- # http://crbug.com/115320
- 'notifications%': 0,
-
'p2p_apis%' : 0,
'gtest_target_type%': 'shared_library',
@@ -1771,6 +1770,9 @@
['enable_task_manager==1', {
'grit_defines': ['-D', 'enable_task_manager'],
}],
+ ['notifications==1', {
+ 'grit_defines': ['-D', 'enable_notifications'],
+ }],
['clang_use_chrome_plugins==1 and OS!="win"', {
'clang_chrome_plugins_flags': [
'<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/app/generated_resources.grd » ('J')

Powered by Google App Engine
This is Rietveld 408576698