Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1601093007: Simplify SVGSVGElement::collectStyleForPresentationAttribute (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify SVGSVGElement::collectStyleForPresentationAttribute There is no need to have the flags separated since they are always used in conjunction. BUG=468897 Committed: https://crrev.com/91c49fb9369f1323d7022402d86aac62b4244cb4 Cr-Commit-Position: refs/heads/master@{#370386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601093007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601093007/1
4 years, 11 months ago (2016-01-20 12:58:38 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 13:58:53 UTC) #6
davve
Probably an oversight that I added instead of extended existing flag back in https://codereview.chromium.org/26390004
4 years, 11 months ago (2016-01-20 14:19:01 UTC) #8
fs
lgtm
4 years, 11 months ago (2016-01-20 14:22:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601093007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601093007/1
4 years, 11 months ago (2016-01-20 14:22:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 14:27:44 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 14:29:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91c49fb9369f1323d7022402d86aac62b4244cb4
Cr-Commit-Position: refs/heads/master@{#370386}

Powered by Google App Engine
This is Rietveld 408576698