Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Unified Diff: chrome/browser/download/download_danger_prompt.cc

Issue 16007017: [Resumption 10/12] Use DI::IsDone to check for terminal downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_danger_prompt.cc
diff --git a/chrome/browser/download/download_danger_prompt.cc b/chrome/browser/download/download_danger_prompt.cc
index 2e3e9c7fd128782621485601031dcfa55cc2b2e3..4e5ae56c07181a51ef8fde5f536e61a45b51b067 100644
--- a/chrome/browser/download/download_danger_prompt.cc
+++ b/chrome/browser/download/download_danger_prompt.cc
@@ -94,9 +94,9 @@ void DownloadDangerPromptImpl::InvokeActionForTesting(Action action) {
void DownloadDangerPromptImpl::OnDownloadUpdated(
content::DownloadItem* download) {
// If the download is nolonger dangerous (accepted externally) or the download
- // doesn't exist anymore, the download danger prompt is no longer necessary.
- if ((download->GetState() != content::DownloadItem::IN_PROGRESS)
- || !download->IsDangerous())
+ // is not going to complete, then the download danger prompt is no longer
+ // necessary.
+ if (!download->IsDangerous() || !download->IsPartialDownload())
Cancel();
}

Powered by Google App Engine
This is Rietveld 408576698