Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 160065: Paste at the beginning of a middle click rather than after letting the page h... (Closed)

Created:
11 years, 5 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Paste at the beginning of a middle click rather than after letting the page handle it. The problem is that the page changes the focused area in the mouse release handler. Even after this fix, it is possible to paste into the wrong place. The place that gets the text is whichever text input is focused when the browser sends back the clipboard contents, not the text input that is focused when the middle click is handled. This has always been true but seems harmless in most cases. BUG=17504 TEST=open gmail chat. Put something in your PRIMARY. Click in the text entry area. Middle click in the chat display area. The selection shouldn't paste into the text entry. Otherwise, middle click paste should still work. TEST=the reduction in the bug acts as expected Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M webkit/glue/webview_impl.cc View 2 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
11 years, 5 months ago (2009-07-23 23:20:46 UTC) #1
agl
11 years, 5 months ago (2009-07-24 02:35:24 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698