Paste at the beginning of a middle click rather than after letting the page h...

webkit/glue/webview_impl.cc

 /*
 * Copyright 2007 Google Inc. All Rights Reserved.
 *
 * Portions Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
 *
 * ***** BEGIN LICENSE BLOCK *****
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
@@ skipping 524 matching lines @@
   target_frame->eventHandler()->sendContextMenuEvent(pme);
   context_menu_allowed_ = false;
   // Actually showing the context menu is handled by the ContextMenuClient
   // implementation...
 }
 
 void WebViewImpl::MouseUp(const WebMouseEvent& event) {
   if (!main_frame() || !main_frame()->frameview())
     return;
 
-  mouseCaptureLost();
-  main_frame()->frame()->eventHandler()->handleMouseReleaseEvent(
-      MakePlatformMouseEvent(main_frame()->frameview(), event));
-
-#if defined(OS_WIN)
-  // Dispatch the contextmenu event regardless of if the click was swallowed.
-  // On Mac/Linux, we handle it on mouse down, not up.
-  if (event.button == WebMouseEvent::ButtonRight)
-    MouseContextMenu(event);
-#endif
-
 #if defined(OS_LINUX)
   // If the event was a middle click, attempt to copy text into the focused
-  // frame.
+  // frame. We execute this before we let the page have a go at the event
+  // because the page may change what is focused during in its event handler.
   //
   // This code is in the mouse up handler. There is some debate about putting
   // this here, as opposed to the mouse down handler.
   //   xterm: pastes on up.
   //   GTK: pastes on down.
   //   Firefox: pastes on up.
   //   Midori: couldn't paste at all with 0.1.2
   //
   // There is something of a webcompat angle to this well, as highlighted by
   // crbug.com/14608. Pages can clear text boxes 'onclick' and, if we paste on
   // down then the text is pasted just before the onclick handler runs and
   // clears the text box. So it's important this happens after the
   // handleMouseReleaseEvent() earlier in this function
   if (event.button == WebMouseEvent::ButtonMiddle) {
     Frame* focused = GetFocusedWebCoreFrame();
-    if (!focused)
-      return;
-    Editor* editor = focused->editor();
-    if (!editor || !editor->canEdit())
-      return;
+    if (focused) {
+      Editor* editor = focused->editor();
+      if (editor && editor->canEdit())
+        delegate_->PasteFromSelectionClipboard();
+    }
+  }
+#endif
 
-    delegate_->PasteFromSelectionClipboard();
-  }
+  mouseCaptureLost();
+  main_frame()->frame()->eventHandler()->handleMouseReleaseEvent(
+      MakePlatformMouseEvent(main_frame()->frameview(), event));
+
+#if defined(OS_WIN)
+  // Dispatch the contextmenu event regardless of if the click was swallowed.
+  // On Mac/Linux, we handle it on mouse down, not up.
+  if (event.button == WebMouseEvent::ButtonRight)
+    MouseContextMenu(event);
 #endif
 }
 
 void WebViewImpl::MouseWheel(const WebMouseWheelEvent& event) {
   MakePlatformWheelEvent platform_event(main_frame()->frameview(), event);
   main_frame()->frame()->eventHandler()->handleWheelEvent(platform_event);
 }
 
 bool WebViewImpl::KeyEvent(const WebKeyboardEvent& event) {
   DCHECK((event.type == WebInputEvent::RawKeyDown) ||
@@ skipping 1329 matching lines @@
 
   return document->focusedNode();
 }
 
 HitTestResult WebViewImpl::HitTestResultForWindowPos(const IntPoint& pos) {
   IntPoint doc_point(
       page_->mainFrame()->view()->windowToContents(pos));
   return page_->mainFrame()->eventHandler()->
       hitTestResultAtPoint(doc_point, false);
 }