CPU profiler should support names of accessors set via v8::Object::SetAccessor

CPU profiler should support names of accessors set via v8::Object::SetAccessor

This change fixes the case when the accessors are invoked from JSObject::{Get,Set}PropertyWithCallback.

It already works for inlined calls generated by StoreStubCompiler::CompileStoreCallback. The same still needs to be fixed for getter invocations generated by  BaseLoadStubCompiler::CompileLoadCallback, corresponding case is commented out in the new test.

BUG=244580
R=jkummerow@chromium.org, loislo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14915

[loislo, 2013-06-03 10:04:50]

https://codereview.chromium.org/16004007/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/16004007/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:747:
env->Global()->Set(v8::String::New("instance"), instance);
please extract the common part about creating an object with getter and setter
into a helper object.

[yurys, 2013-06-03 10:07:29]

https://codereview.chromium.org/16004007/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/16004007/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:747:
env->Global()->Set(v8::String::New("instance"), instance);
On 2013/06/03 10:04:50, loislo wrote:
> please extract the common part about creating an object with getter and setter
> into a helper object.

I'm going to do extract this code into a function with two int parameters when
check at line 775 is passing. I will address this in a separate change.

[loislo, 2013-06-03 10:08:56]

lgtm

[loislo, 2013-06-03 10:09:38]

On 2013/06/03 10:08:56, loislo wrote:
> lgtm

please add a comment about the goal of the second test.

[Jakob Kummerow, 2013-06-03 10:48:57]

rubber-stamp LGTM so you can land this. I'm leaving the functional review to
loislo@.

[yurys, 2013-06-03 11:47:07]

On 2013/06/03 10:09:38, loislo wrote:
> On 2013/06/03 10:08:56, loislo wrote:
> > lgtm
> 
> please add a comment about the goal of the second test.

Done.

[yurys, 2013-06-03 12:50:12]

Committed patchset #3 manually as r14915 (presubmit successful).