Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: src/objects.cc

Issue 16004007: CPU profiler should support names of accessors set via v8::Object::SetAccessor (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Use OS::Ticks for better control over the accessor execution time Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index c94a6972118a3f8f767555e6736b2774ada1d8e6..f914e15dd00e60909b1f86fd024b641db6bd9c20 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -344,6 +344,8 @@ MaybeObject* JSObject::GetPropertyWithCallback(Object* receiver,
{
// Leaving JavaScript.
VMState<EXTERNAL> state(isolate);
+ ExternalCallbackScope call_scope(isolate,
+ v8::ToCData<Address>(fun_obj));
result = args.Call(call_fun, v8::Utils::ToLocal(key));
}
RETURN_IF_SCHEDULED_EXCEPTION(isolate);
@@ -2789,6 +2791,8 @@ MaybeObject* JSObject::SetPropertyWithCallback(Object* structure,
{
// Leaving JavaScript.
VMState<EXTERNAL> state(isolate);
+ ExternalCallbackScope call_scope(isolate,
+ v8::ToCData<Address>(call_obj));
args.Call(call_fun,
v8::Utils::ToLocal(key),
v8::Utils::ToLocal(value_handle));
« no previous file with comments | « no previous file | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698