Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 160033002: Better restriction to prevent Windows git install on XP or older. (Closed)

Created:
6 years, 10 months ago by Michael Moss
Modified:
6 years, 10 months ago
Reviewers:
szager, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Better restriction to prevent Windows git install on XP or older. This is in preparation for once again making 1.8.5.2 the default Windows git. Also remove the CHROME_HEADLESS condition, which confuses bot setup because the same bot will sometimes run without that set (e.g. at slave startup) and with it set (e.g. during a build), leading to the wrong, or even no, git installed. R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250486

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M bootstrap/win/win_tools.bat View 2 chunks +12 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
Michael Moss
6 years, 10 months ago (2014-02-11 19:51:39 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/160033002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/160033002/diff/1/bootstrap/win/win_tools.bat#newcode40 bootstrap/win/win_tools.bat:40: for /f "tokens=2 delims=[]" %%i in ('ver') do ...
6 years, 10 months ago (2014-02-11 20:11:12 UTC) #2
Michael Moss
https://codereview.chromium.org/160033002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/160033002/diff/1/bootstrap/win/win_tools.bat#newcode40 bootstrap/win/win_tools.bat:40: for /f "tokens=2 delims=[]" %%i in ('ver') do set ...
6 years, 10 months ago (2014-02-11 20:14:22 UTC) #3
Michael Moss
6 years, 10 months ago (2014-02-11 20:19:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r250486.

Powered by Google App Engine
This is Rietveld 408576698