Better restriction to prevent Windows git install on XP or older.

bootstrap/win/win_tools.bat

 @echo off
 :: Copyright (c) 2012 The Chromium Authors. All rights reserved.
 :: Use of this source code is governed by a BSD-style license that can be
 :: found in the LICENSE file.
 
 :: This script will try to find if svn and python are accessible and it not,
 :: it will try to download it and 'install' it in depot_tools.
 
 :: Sadly, we can't use SETLOCAL here otherwise it ERRORLEVEL is not correctly
 :: returned.
@@ skipping 17 matching lines @@
 :GIT_CHECK
 if "%DEPOT_TOOLS_GIT_1852%" == "1" goto :GIT_1852_CHECK
 :: Our new build of git doesn't work on some systems (e.g. uses newer APIs than
 :: available in XP), so force systems back to the old git while the failures
 :: are investigated, unless the new git was explicitly requested above.
 goto :GIT_180_FORCE
 
 
 :GIT_1852_CHECK
 set GIT_VERSION=1.8.5.2.chromium.1
+:: This git uses APIs that target WINVER 0x0502, so refuse to install it on
+:: anything older.
+for /f "tokens=2 delims=[]" %%i in ('ver') do set VERSTR=%%i

[M-A Ruel, 2014/02/11 20:11:13]

Somewhat rubberstamp, it's been a long time since I had fun with batch file
syntax.

[Michael Moss, 2014/02/11 20:14:22]

Yeah, me too, and I have no idea if this is the best way to do it, but I tested
on both an XP and Win7 bot, and it appears to do the right thing.

+for /f "tokens=2,3 delims=. " %%i in ("%VERSTR%") do (set VERMAJOR=%%i & set VERMINOR=%%j)
+if %VERMAJOR% lss 5 goto :GIT_VER_UNSUPPORTED
+if %VERMAJOR% equ 5 if %VERMINOR% lss 2 goto :GIT_VER_UNSUPPORTED
 set GIT_BIN_DIR=git-%GIT_VERSION%_bin
 set GIT_ZIP_FILE=%GIT_BIN_DIR%.zip
 set GIT_ZIP_URL=https://commondatastorage.googleapis.com/chrome-infra/%GIT_ZIP_FILE%
 goto :GIT_COMMON
 
 
+:GIT_VER_UNSUPPORTED
+echo Git %GIT_VERSION% cannot be installed on:
+ver
+goto :GIT_180_CHECK
+
+
 :GIT_180_FORCE
 :: If the new git was installed, remove all installed git packages to trigger
 :: reinstallation of the old version.
 if exist "%WIN_TOOLS_ROOT_DIR%\git-1.8.5.2.chromium.1_bin" (
   rmdir /S /Q "%WIN_TOOLS_ROOT_DIR%\git-1.8.5.2.chromium.1_bin"
   if exist "%WIN_TOOLS_ROOT_DIR%\git-1.8.0_bin" (
     rmdir /S /Q "%WIN_TOOLS_ROOT_DIR%\git-1.8.0_bin"
   )
 )
 goto :GIT_180_CHECK
 
 
 :GIT_180_CHECK
 set GIT_VERSION=1.8.0
 set GIT_BIN_DIR=git-%GIT_VERSION%_bin
 set GIT_ZIP_FILE=%GIT_BIN_DIR%.zip
 set GIT_ZIP_URL=%WIN_TOOLS_ROOT_URL%/third_party/%GIT_ZIP_FILE%
 goto :GIT_COMMON
 
 
 :GIT_COMMON
 :: If the batch file exists, skip the git check.
 if exist "%WIN_TOOLS_ROOT_DIR%\%GIT_BIN_DIR%" goto :MSYS_PATH_CHECK
-if "%CHROME_HEADLESS%" == "1" goto :SVN_CHECK
 if "%WIN_TOOLS_FORCE%" == "1" goto :GIT_INSTALL
 call git --version 2>nul 1>nul
 if errorlevel 1 goto :GIT_INSTALL
 goto :SVN_CHECK
 
 
 :MSYS_PATH_CHECK
 call find "mingw" "%WIN_TOOLS_ROOT_DIR%\%GIT_BIN_DIR%\cmd\git.cmd" 2>nul 1>nul
 if errorlevel 1 goto :SVN_CHECK
 rmdir /S /Q "%WIN_TOOLS_ROOT_DIR%\%GIT_BIN_DIR%"
@@ skipping 134 matching lines @@
 goto :END
 
 
 :returncode
 set WIN_TOOLS_ROOT_URL=
 set WIN_TOOLS_ROOT_DIR=
 exit /b %ERRORLEVEL%
 
 :END
 call :returncode %ERRORLEVEL%