Fixed crash when clicking empty select element....

Fixed crash when clicking empty select element.

BUG=4334
(http://crbug.com/4334)

TEST=<select></select>

I believe this is not needed:
if (windowHeight == 0)	
  windowHeight = min(getRowHeight(-1), kMaxHeight);

windowHeight is dependent on the number of items within the popup, if you have no items within the popup, it returns 0. I don't understand why we need to do "min(getRowHeight(-1), kMaxHeight)" when its 0, that doesn't make sense to me. Since getRowHeight gets the height of that item@index, everyone knows there are no item for index -1 (hence crash).

:x

[Mohamed Mansour (USE mhm), 2008-12-20 18:16:42]

changed reviewers (IRC)

[darin (slow to review), 2008-12-20 18:24:24]

http://codereview.chromium.org/16001/diff/1/2
File webkit/port/platform/chromium/PopupMenuChromium.cpp (left):

http://codereview.chromium.org/16001/diff/1/2#oldcode1039
Line 1039: windowHeight = min(getRowHeight(-1), kMaxHeight);
it is not obvious to me why you are removing this code.  it would be good to
explain that in the CL description.

[Mohamed Mansour (USE mhm), 2008-12-20 18:32:25]

updated CL why I believe its not needed

[darin (slow to review), 2008-12-20 18:38:22]

makes sense.  LGTM!

[darin (slow to review), 2008-12-20 18:42:35]

committed as r7347

[Peter Kasting, 2008-12-20 22:30:49]

On 2008/12/20 18:42:35, darin wrote:
> committed as r7347

I'm late to the party here, but note that files in port are WebKit style, and
WebKit style forbids {} on single-line conditional arms (they're stricter than
google3 style on this one).  We should probably do a followup to keep this
WebKit-style-compliant (I'd just do this but am not at my work machine).

[Mohamed Mansour (USE mhm), 2008-12-21 02:47:12]

On 2008/12/20 22:30:49, pkasting wrote:
> I'm late to the party here, but note that files in port are WebKit style, and
> WebKit style forbids {} on single-line conditional arms (they're stricter than
> google3 style on this one).  We should probably do a followup to keep this
> WebKit-style-compliant (I'd just do this but am not at my work machine).

Hmm, I could clean up the code and use webkit style, I didn't know if port was
supposed to be webkit cause it is just an interface to WebCore ( i thought) and
I was following the other example in the same file.

Do you want me to open another review and fix the style ?