Fixed crash when clicking empty select element....

webkit/port/platform/chromium/PopupMenuChromium.cpp

 // Copyright (c) 2008, Google Inc.
 // All rights reserved.
 // 
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 // 
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 875 matching lines @@
     }
 }
 
 void PopupListBox::setOriginalIndex(int index)
 {
     m_originalIndex = m_selectedIndex = index;
 }
 
 int PopupListBox::getRowHeight(int index)
 {
-    return m_popupClient->itemStyle(index).font().height();
+    if (index >= 0) {
+        return m_popupClient->itemStyle(index).font().height();
+    } else {
+        return 0;
+    }
 }
 
 IntRect PopupListBox::getRowBounds(int index)
 {
     if (index >= 0) {
         return IntRect(0, m_items[index]->y, visibleWidth(), getRowHeight(index));
     } else {
         return IntRect(0, 0, visibleWidth(), getRowHeight(index));
     }
 }
@@ skipping 121 matching lines @@
     for (int i = 0; i < m_visibleRows; ++i) {
         int rowHeight = getRowHeight(i);
         if (windowHeight + rowHeight > kMaxHeight) {
             m_visibleRows = i;
             break;
         }
 
         windowHeight += rowHeight;
     }
 
-    if (windowHeight == 0)
-        windowHeight = min(getRowHeight(-1), kMaxHeight);

[darin (slow to review), 2008/12/20 18:24:25]

it is not obvious to me why you are removing this code.  it would be good to
explain that in the CL description.

-
     // Set our widget and scrollable contents sizes.
     int scrollbarWidth = 0;
     if (m_visibleRows < numItems())
         scrollbarWidth = ScrollbarTheme::nativeTheme()->scrollbarThickness();
 
     int windowWidth = baseWidth + scrollbarWidth + paddingWidth;
     int contentWidth = baseWidth;
 
     if (windowWidth < m_baseWidth) {
         windowWidth = m_baseWidth;
         contentWidth = m_baseWidth - scrollbarWidth - paddingWidth;
     } else {
         m_baseWidth = baseWidth;
     }
 
     resize(windowWidth, windowHeight);
     setContentsSize(IntSize(contentWidth, getRowBounds(numItems() - 1).bottom()));
-    
+
     if (hostWindow())
         scrollToRevealSelection();
 
     invalidate();
 }
 
 void PopupListBox::clear()
 {
     for (Vector<ListItem*>::iterator it = m_items.begin(); it != m_items.end(); ++it)
         delete *it;
@@ skipping 41 matching lines @@
 {
     p.m_popup->listBox()->updateFromElement();
 }
 
 bool PopupMenu::itemWritingDirectionIsNatural() 
 { 
     return false; 
 }
 
 } // namespace WebCore