Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 159983010: [Android WebView] Turn off compatibility quirks in tests (Closed)

Created:
6 years, 10 months ago by mnaganov (inactive)
Modified:
6 years, 10 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Turn off compatibility quirks in tests All tests now run in "quirkless" mode, except for the tests that explicitly test quirks behavior. Since almost all of them are in AwViewportTest suite, I have moved the remaining one from AwSettingsTest into it, and renamed AwViewportTest to AwLegacyQuirksTest. BUG=278106 R=benm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251681

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment and rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -353 lines) Patch
A + android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java View 1 10 chunks +46 lines, -10 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 chunk +0 lines, -30 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 4 chunks +3 lines, -5 lines 0 comments Download
D android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java View 1 chunk +0 lines, -308 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mnaganov (inactive)
Ben, PTAL! Seems to work on bots. Red steps on bots doesn't relate to our ...
6 years, 10 months ago (2014-02-12 16:09:24 UTC) #1
mnaganov (inactive)
On 2014/02/12 16:09:24, Mikhail Naganov (Cr) wrote: > Ben, PTAL! > > Seems to work ...
6 years, 10 months ago (2014-02-14 08:45:13 UTC) #2
benm (inactive)
lgtm https://codereview.chromium.org/159983010/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java (right): https://codereview.chromium.org/159983010/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java#newcode330 android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java:330: private AwTestContainerView createAwTestContainerViewOnMainSyncInLegacyMode( nit: s/legacy/quirks/ ?
6 years, 10 months ago (2014-02-14 13:29:24 UTC) #3
mnaganov (inactive)
Thanks, Ben! https://codereview.chromium.org/159983010/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java (right): https://codereview.chromium.org/159983010/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java#newcode330 android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java:330: private AwTestContainerView createAwTestContainerViewOnMainSyncInLegacyMode( On 2014/02/14 13:29:24, benm ...
6 years, 10 months ago (2014-02-17 13:32:40 UTC) #4
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 10 months ago (2014-02-17 13:40:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/159983010/120001
6 years, 10 months ago (2014-02-17 13:40:34 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 14:37:50 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265333
6 years, 10 months ago (2014-02-17 14:37:50 UTC) #8
mnaganov (inactive)
6 years, 10 months ago (2014-02-17 16:18:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r251681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698