Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

Issue 159983010: [Android WebView] Turn off compatibility quirks in tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comment and rebased Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
index 7f9d5e81b4fdb3bce97594c3743a9977242f8b26..421070dfe314b5ea7e66fe0a8bcca563cfc9f51c 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
@@ -275,7 +275,7 @@ public class AwTestBase
protected AwTestContainerView createAwTestContainerView(
final AwContentsClient awContentsClient) {
- return createAwTestContainerView(awContentsClient, true);
+ return createAwTestContainerView(awContentsClient, false);
}
protected AwTestContainerView createAwTestContainerView(
@@ -293,7 +293,7 @@ public class AwTestBase
protected AwTestContainerView createDetachedAwTestContainerView(
final AwContentsClient awContentsClient) {
- return createDetachedAwTestContainerView(awContentsClient, true);
+ return createDetachedAwTestContainerView(awContentsClient, false);
}
protected AwTestContainerView createDetachedAwTestContainerView(
@@ -303,8 +303,6 @@ public class AwTestBase
testDependencyFactory.createAwTestContainerView(getActivity());
AwSettings awSettings = testDependencyFactory.createAwSettings(getActivity(),
supportsLegacyQuirks);
- // TODO(mnaganov): Should also have tests for the "pure Chromium" mode.
- // See http://crbug.com/278106
testContainerView.initialize(new AwContents(
mBrowserContext, testContainerView, testContainerView.getInternalAccessDelegate(),
awContentsClient, awSettings, testDependencyFactory.createLayoutSizer()));
@@ -314,7 +312,7 @@ public class AwTestBase
protected AwTestContainerView createAwTestContainerViewOnMainSync(
final AwContentsClient client) throws Exception {
- return createAwTestContainerViewOnMainSync(client, true);
+ return createAwTestContainerViewOnMainSync(client, false);
}
protected AwTestContainerView createAwTestContainerViewOnMainSync(

Powered by Google App Engine
This is Rietveld 408576698