Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 159983003: Fix a bug with mojom imports where 2 imports with the same namespace would (Closed)

Created:
6 years, 10 months ago by Matt Perry
Modified:
6 years, 10 months ago
CC:
chromium-reviews, viettrungluu+watch_chromium.org, tfarina, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Fix a bug with mojom imports where 2 imports with the same namespace would cause a variable name collision in JS. BUG=325500 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251105

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -53 lines) Patch
M mojo/apps/js/bindings/sample_service_unittests.js View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/generators/js_templates/module.js.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/generators/js_templates/struct_definition.tmpl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/generators/mojom_cpp_generator.py View 2 chunks +7 lines, -22 lines 0 comments Download
M mojo/public/bindings/generators/mojom_js_generator.py View 1 2 3 3 chunks +25 lines, -2 lines 0 comments Download
M mojo/public/bindings/mojom_bindings_generator.py View 4 chunks +9 lines, -5 lines 0 comments Download
M mojo/public/bindings/pylib/generate/mojom.py View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/public/bindings/pylib/generate/mojom_data.py View 2 chunks +14 lines, -13 lines 0 comments Download
M mojo/public/bindings/tests/sample_import.mojom View 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/bindings/tests/sample_import2.mojom View 1 chunk +29 lines, -0 lines 0 comments Download
M mojo/public/bindings/tests/sample_service.mojom View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/bindings/tests/sample_service_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Matt Perry
https://codereview.chromium.org/159983003/diff/1/mojo/public/bindings/mojom_bindings_generator.py File mojo/public/bindings/mojom_bindings_generator.py (right): https://codereview.chromium.org/159983003/diff/1/mojo/public/bindings/mojom_bindings_generator.py#newcode69 mojo/public/bindings/mojom_bindings_generator.py:69: args, generator_modules, import_filename, processed_files) I made this change because ...
6 years, 10 months ago (2014-02-11 19:46:05 UTC) #1
darin (slow to review)
LGTM
6 years, 10 months ago (2014-02-12 18:25:15 UTC) #2
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 10 months ago (2014-02-12 22:43:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/159983003/220001
6 years, 10 months ago (2014-02-12 22:46:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 01:31:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262935
6 years, 10 months ago (2014-02-13 01:31:12 UTC) #6
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 10 months ago (2014-02-13 01:37:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/159983003/220001
6 years, 10 months ago (2014-02-13 01:41:59 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 03:19:45 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263181
6 years, 10 months ago (2014-02-13 03:19:46 UTC) #10
Matt Perry
6 years, 10 months ago (2014-02-13 20:13:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 manually as r251105 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698