Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: mojo/public/bindings/generators/mojom_js_generator.py

Issue 159983003: Fix a bug with mojom imports where 2 imports with the same namespace would (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Generates JavaScript source files from a mojom.Module.""" 5 """Generates JavaScript source files from a mojom.Module."""
6 6
7 from generate import mojom 7 from generate import mojom
8 from generate import mojom_pack 8 from generate import mojom_pack
9 from generate import mojom_generator 9 from generate import mojom_generator
10 10
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 if kind in mojom.PRIMITIVES: 141 if kind in mojom.PRIMITIVES:
142 return _kind_to_javascript_encode_snippet[kind] 142 return _kind_to_javascript_encode_snippet[kind]
143 if isinstance(kind, mojom.Struct): 143 if isinstance(kind, mojom.Struct):
144 return "encodeStructPointer(%s, " % GetJavaScriptType(kind.name); 144 return "encodeStructPointer(%s, " % GetJavaScriptType(kind.name);
145 if isinstance(kind, mojom.Array): 145 if isinstance(kind, mojom.Array):
146 return "encodeArrayPointer(%s, " % GetJavaScriptType(kind.kind); 146 return "encodeArrayPointer(%s, " % GetJavaScriptType(kind.kind);
147 if isinstance(kind, mojom.Interface): 147 if isinstance(kind, mojom.Interface):
148 return JavaScriptEncodeSnippet(mojom.MSGPIPE) 148 return JavaScriptEncodeSnippet(mojom.MSGPIPE)
149 149
150 150
151 def SubstituteNamespace(value, imports):
152 for import_item in imports:
153 value = value.replace(import_item["namespace"] + ".",
154 import_item["unique_name"] + ".")
155 return value
156
157
158 def JavascriptType(kind):
159 if kind.imported_from:
160 return kind.imported_from["unique_name"] + "." + kind.name
161 return kind.name
162
163
151 class Generator(mojom_generator.Generator): 164 class Generator(mojom_generator.Generator):
152 165
153 js_filters = { 166 js_filters = {
154 "camel_to_underscores": mojom_generator.CamelToUnderscores, 167 "camel_to_underscores": mojom_generator.CamelToUnderscores,
155 "default_value": JavaScriptDefaultValue, 168 "default_value": JavaScriptDefaultValue,
156 "payload_size": JavaScriptPayloadSize, 169 "payload_size": JavaScriptPayloadSize,
157 "decode_snippet": JavaScriptDecodeSnippet, 170 "decode_snippet": JavaScriptDecodeSnippet,
158 "encode_snippet": JavaScriptEncodeSnippet, 171 "encode_snippet": JavaScriptEncodeSnippet,
159 "is_object_kind": mojom_generator.IsObjectKind, 172 "is_object_kind": mojom_generator.IsObjectKind,
160 "is_string_kind": mojom_generator.IsStringKind, 173 "is_string_kind": mojom_generator.IsStringKind,
161 "is_array_kind": lambda kind: isinstance(kind, mojom.Array), 174 "is_array_kind": lambda kind: isinstance(kind, mojom.Array),
162 "js_type": lambda kind: kind.GetFullName("."), 175 "js_type": JavascriptType,
163 "stylize_method": mojom_generator.StudlyCapsToCamel, 176 "stylize_method": mojom_generator.StudlyCapsToCamel,
177 "substitute_namespace": SubstituteNamespace,
164 "verify_token_type": mojom_generator.VerifyTokenType, 178 "verify_token_type": mojom_generator.VerifyTokenType,
165 } 179 }
166 180
167 @UseJinja("js_templates/module.js.tmpl", filters=js_filters) 181 @UseJinja("js_templates/module.js.tmpl", filters=js_filters)
168 def GenerateJsModule(self): 182 def GenerateJsModule(self):
169 return { 183 return {
170 "imports": self.module.imports, 184 "imports": self.GetImports(),
171 "kinds": self.module.kinds, 185 "kinds": self.module.kinds,
172 "enums": self.module.enums, 186 "enums": self.module.enums,
173 "structs": self.GetStructs() + self.GetStructsFromMethods(), 187 "structs": self.GetStructs() + self.GetStructsFromMethods(),
174 "interfaces": self.module.interfaces, 188 "interfaces": self.module.interfaces,
175 } 189 }
176 190
177 def GenerateFiles(self): 191 def GenerateFiles(self):
178 self.Write(self.GenerateJsModule(), "%s.js" % self.module.name) 192 self.Write(self.GenerateJsModule(), "%s.js" % self.module.name)
193
194 def GetImports(self):
195 # Since each import is assigned a variable in JS, they need to have unique
196 # names.
197 counter = 1
198 for each in self.module.imports:
199 each["unique_name"] = "import" + str(counter)
200 counter += 1
201 return self.module.imports
OLDNEW
« no previous file with comments | « mojo/public/bindings/generators/mojom_cpp_generator.py ('k') | mojo/public/bindings/mojom_bindings_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698