Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 159973005: Add tests for |undefined| and |null| in SVG interfaces (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Add tests for |undefined| and |null| in SVG interfaces Many SVG interfaces do not allow undefined or null arguments; these should throw an exception, and not crash. This can be done by adding [StrictTypeChecking] to the interface, once a bindings change is made: Add [StrictTypeChecking] to the SVGGeometryElement interface https://codereview.chromium.org/144463014/ Currently many test cases are missing, so we have crasher bugs from ClusterFuzz. This CL adds test cases for these. TBR=haraken BUG=341810 BUG=342741 BUG=341379 BUG=341620 BUG=345199 BUG=341030 BUG=341776 BUG=344474 BUG=345191 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166979

Patch Set 1 #

Patch Set 2 : Tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -2 lines) Patch
A LayoutTests/svg/dom/undefined-null.html View 1 1 chunk +91 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/undefined-null-expected.txt View 1 chunk +53 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.idl View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
Test cases for the SVG undefined/null crashes.
6 years, 10 months ago (2014-02-12 03:43:56 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-12 03:44:02 UTC) #2
haraken
LGTM. It's sad that so many tests are crashing and failing.
6 years, 10 months ago (2014-02-12 03:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/159973005/30001
6 years, 10 months ago (2014-02-12 03:53:11 UTC) #4
Nils Barth (inactive)
On 2014/02/12 03:50:28, haraken wrote: > LGTM. It's sad that so many tests are crashing ...
6 years, 10 months ago (2014-02-12 03:53:49 UTC) #5
Nils Barth (inactive)
On 2014/02/12 03:53:49, Nils Barth wrote: > Florin's CL (one-line fix) will fix all of ...
6 years, 10 months ago (2014-02-12 07:18:05 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 07:53:34 UTC) #7
Message was sent while issue was closed.
Change committed as 166979

Powered by Google App Engine
This is Rietveld 408576698