compositor-worker: Remove code from cc_blink

third_party/WebKit/Source/platform/graphics/CompositorMutableProperties.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CompositorMutableProperties_h
+#define CompositorMutableProperties_h
+
+namespace blink {
+
+// TODO(vollick): we should not need a parallel enum. This must be kept in sync
+// with the cc::MutableProperty enum. Once we build property trees in blink, the
+// compositor does not need to know about these mutable properties and the
+// compositor-side enumeration can be removed.
+enum CompositorMutableProperty {

[esprehn, 2016/01/21 20:05:25]

Talk to Dana about how to remove this she removed one recently. It also removes
all your casts all over.

[Ian Vollick, 2016/01/21 20:08:37]

Sounds good. I'll ask her.

[danakj, 2016/01/21 20:54:26]

First, bitmask flags aren't enums (a set of things where you choose one),
they're a set of constants. :)

https://codereview.chromium.org/1602773006/ is what elliot is referring to. I
made the blink "enum" be a type alias to a cc enum instead of duplicating it and
casting/static_asserting equivalence.

+    CompositorMutablePropertyNone = 0,
+    CompositorMutablePropertyOpacity = 1 << 0,
+    CompositorMutablePropertyScrollLeft = 1 << 1,
+    CompositorMutablePropertyScrollTop = 1 << 2,
+    CompositorMutablePropertyTransform = 1 << 3,
+};
+
+const int kNumCompositorMutableProperties = 4;

[danakj, 2016/01/21 20:54:26]

Don't use storage for constants in header files.
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/hDqJ4KBVqog/dis...

The way to write this is
enum : int { kNumCompositorMutableProperties = 4; }

With the enum both anonymous and with a single member. It's in the chromium
style guide after the above thread also.

+
+} // namespace blink
+
+#endif // CompositorMutableProperties_h