Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 159963002: More check elimination improvements including partial learning on false branches of CompareMap and b (Closed)

Created:
6 years, 10 months ago by Igor Sheludko
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

More check elimination improvements including partial learning on false branches of CompareMap and better handling of unreachable blocks. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19300

Patch Set 1 : Refactoring flow engine: state copying and merging replaced with merging and finishing procedures. #

Patch Set 2 : More check elimination improvements including partial learning on false branches of CompareMap and … #

Patch Set 3 : Code cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -78 lines) Patch
M src/hydrogen.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/hydrogen-check-elimination.cc View 1 2 10 chunks +123 lines, -63 lines 0 comments Download
M src/hydrogen-flow-engine.h View 2 chunks +8 lines, -11 lines 0 comments Download
M src/hydrogen-load-elimination.cc View 2 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
LGTM (Although for the record, I don't really like marking blocks unreachable in the middle ...
6 years, 10 months ago (2014-02-11 18:52:43 UTC) #1
Igor Sheludko
PTAL
6 years, 10 months ago (2014-02-11 19:11:40 UTC) #2
Igor Sheludko
On 2014/02/11 19:11:40, Igor Sheludko wrote: > PTAL Actually this analysis not only eliminates checks ...
6 years, 10 months ago (2014-02-11 19:15:43 UTC) #3
Igor Sheludko
6 years, 10 months ago (2014-02-11 19:18:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r19300 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698