Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1599413006: Remove catapult_base from telemetry. (Closed)

Created:
4 years, 11 months ago by aiolos (Not reviewing)
Modified:
4 years, 11 months ago
Reviewers:
eakuefner
CC:
chromium-reviews, telemetry-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@perf_cb_move
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove catapult_base from telemetry. This is dependent on https://codereview.chromium.org/1568103002/ and https://codereview.chromium.org/1565403005/ landing. BUG=565604 Committed: https://crrev.com/a32c24edfa6d09499ba873ba616b35a1de8912e5 Cr-Commit-Position: refs/heads/master@{#370630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -2728 lines) Patch
D tools/telemetry/catapult_base/__init__.py View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/telemetry/catapult_base/bin/run_tests View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/telemetry/catapult_base/cloud_storage.py View 1 chunk +0 lines, -348 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/__init__.py View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/archive_info.py View 1 chunk +0 lines, -69 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/base_config.py View 1 chunk +0 lines, -380 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/cloud_storage_info.py View 1 chunk +0 lines, -110 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/dependency_info.py View 1 chunk +0 lines, -123 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/dependency_manager.py View 1 chunk +0 lines, -172 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/dependency_manager_util.py View 1 chunk +0 lines, -95 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/exceptions.py View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/local_path_info.py View 1 chunk +0 lines, -40 lines 0 comments Download
D tools/telemetry/catapult_base/dependency_manager/uploader.py View 1 chunk +0 lines, -106 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/__init__.py View 1 chunk +0 lines, -28 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/annotated_symbol/__init__.py View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/annotated_symbol/base_symbol.py View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/annotated_symbol/class_definition.py View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/annotated_symbol/function_definition.py View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/annotated_symbol/import_statement.py View 1 chunk +0 lines, -322 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/annotated_symbol/reference.py View 1 chunk +0 lines, -75 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/module.py View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/offset_token.py View 1 chunk +0 lines, -113 lines 0 comments Download
D tools/telemetry/catapult_base/refactor/snippet.py View 1 chunk +0 lines, -242 lines 0 comments Download
D tools/telemetry/catapult_base/refactor_util/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/telemetry/catapult_base/refactor_util/move.py View 1 chunk +0 lines, -115 lines 0 comments Download
D tools/telemetry/catapult_base/test_data/foo.txt View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/catapult_base/util.py View 1 chunk +0 lines, -25 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (7 generated)
aiolos (Not reviewing)
4 years, 11 months ago (2016-01-20 01:33:14 UTC) #3
eakuefner
lgtm https://i.imgur.com/7drHiqrh.jpg
4 years, 11 months ago (2016-01-20 01:35:07 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1599413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1599413006/1
4 years, 11 months ago (2016-01-20 19:48:54 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/167764) win_chromium_rel_ng on ...
4 years, 11 months ago (2016-01-20 20:31:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1599413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1599413006/1
4 years, 11 months ago (2016-01-21 03:52:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 05:16:30 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a32c24edfa6d09499ba873ba616b35a1de8912e5 Cr-Commit-Position: refs/heads/master@{#370630}
4 years, 11 months ago (2016-01-21 05:17:12 UTC) #14
aiolos (Not reviewing)
4 years, 11 months ago (2016-01-21 22:50:21 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1620023002/ by aiolos@chromium.org.

The reason for reverting is: Breaks gpu_tests..

Powered by Google App Engine
This is Rietveld 408576698