Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 15994016: Support custom window features, such as 'moo=foo'. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.cc
===================================================================
--- content/browser/browser_plugin/browser_plugin_guest.cc (revision 198276)
+++ content/browser/browser_plugin/browser_plugin_guest.cc (working copy)
@@ -453,11 +453,13 @@
return source;
}
-void BrowserPluginGuest::WebContentsCreated(WebContents* source_contents,
- int64 source_frame_id,
- const string16& frame_name,
- const GURL& target_url,
- WebContents* new_contents) {
+void BrowserPluginGuest::WebContentsCreated(
+ WebContents* source_contents,
sky 2013/06/04 23:08:33 4 space indent here too.
+ int64 source_frame_id,
+ const string16& frame_name,
+ const GURL& target_url,
+ const WebKit::WindowFeatures& web_window_features,
+ WebContents* new_contents) {
WebContentsImpl* new_contents_impl =
static_cast<WebContentsImpl*>(new_contents);
BrowserPluginGuest* guest = new_contents_impl->GetBrowserPluginGuest();

Powered by Google App Engine
This is Rietveld 408576698