Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 15994016: Support custom window features, such as 'moo=foo'. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/browser/browser_plugin/browser_plugin_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_guest.h
===================================================================
--- content/browser/browser_plugin/browser_plugin_guest.h (revision 198276)
+++ content/browser/browser_plugin/browser_plugin_guest.h (working copy)
@@ -196,11 +196,13 @@
const NativeWebKeyboardEvent& event) OVERRIDE;
virtual WebContents* OpenURLFromTab(WebContents* source,
const OpenURLParams& params) OVERRIDE;
- virtual void WebContentsCreated(WebContents* source_contents,
- int64 source_frame_id,
- const string16& frame_name,
- const GURL& target_url,
- WebContents* new_contents) OVERRIDE;
+ virtual void WebContentsCreated(
+ WebContents* source_contents,
sky 2013/06/04 23:08:33 nit: change this to 4 space indent (same as 195).
+ int64 source_frame_id,
+ const string16& frame_name,
+ const GURL& target_url,
+ const WebKit::WindowFeatures& web_window_features,
+ WebContents* new_contents) OVERRIDE;
virtual void RendererUnresponsive(WebContents* source) OVERRIDE;
virtual void RendererResponsive(WebContents* source) OVERRIDE;
virtual void RunFileChooser(WebContents* web_contents,
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/browser/browser_plugin/browser_plugin_guest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698