Issue 15994003: remove most remaining V8_ALLOW_ACCESS_TO* defines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15994003: remove most remaining V8_ALLOW_ACCESS_TO* defines (Closed)

Created:
7 years, 6 months ago by dcarney

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

remove most remaining V8_ALLOW_ACCESS_TO* defines R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14870

Patch Set 2 : addressed comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -74 lines)			Patch
M	include/v8.h	View	1	6 chunks	+31 lines, -12 lines	0 comments	Download
M	samples/lineprocessor.cc	View		3 chunks	+2 lines, -7 lines	0 comments	Download
M	samples/process.cc	View		7 chunks	+12 lines, -13 lines	0 comments	Download
M	samples/shell.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/d8.cc	View		14 chunks	+31 lines, -27 lines	0 comments	Download
M	src/mksnapshot.cc	View		4 chunks	+2 lines, -7 lines	0 comments	Download
M	src/runtime.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit. https://codereview.chromium.org/15994003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/15994003/diff/1/include/v8.h#newcode378 include/v8.h:378: template<class F> Similar code has ...

7 years, 6 months ago (2013-05-29 07:54:54 UTC) #2

dcarney

7 years, 6 months ago (2013-05-29 08:39:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14870 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15994003: remove most remaining V8_ALLOW_ACCESS_TO* defines (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comments #

Messages