samples/shell.cc - Issue 15994003: remove most remaining V8_ALLOW_ACCESS_TO* defines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/shell.cc

Issue 15994003: remove most remaining V8_ALLOW_ACCESS_TO* defines (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/shell.cc

diff --git a/samples/shell.cc b/samples/shell.cc

index da18cc71d3b906a267ae4eed2317da3a8bbc0962..430dd966e125badbcf34cce6916f6479822aedc9 100644

--- a/samples/shell.cc

+++ b/samples/shell.cc

@@ -25,11 +25,6 @@

// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// TODO(dcarney): remove this

-#define V8_ALLOW_ACCESS_TO_RAW_HANDLE_CONSTRUCTOR

-#define V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT

-#define V8_ALLOW_ACCESS_TO_PERSISTENT_ARROW

#include <v8.h>

#include <assert.h>

#include <fcntl.h>

« no previous file with comments | « samples/process.cc ('k') | src/d8.cc » ('j') | no next file with comments »